Eliminate fb prefix from service_extensions.js

RESOLVED FIXED in Firefox OS master

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mancas, Assigned: mancas)

Tracking

unspecified
FxOS-S2 (10Jul)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-master fixed)

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
As part of the Meta Bug 1173013 that removes current FB integration from Contacts, we need to eliminate "fb-" prefixes from service_extensions.js
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
No longer blocks: 1178646
Created attachment 8630956 [details] [review]
[gaia] mancas:bug1181112 > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8630956 [details] [review]
[gaia] mancas:bug1181112 > mozilla-b2g:master

Could you take a quick look at the patch?

Thanks =)
Attachment #8630956 - Flags: review?(borja.bugzilla)
Target Milestone: --- → FxOS-S2 (10Jul)
Depends on: 1180135
Comment on attachment 8630956 [details] [review]
[gaia] mancas:bug1181112 > mozilla-b2g:master

This patch depends on https://bugzilla.mozilla.org/show_bug.cgi?id=1180135. Please rebase when the former patch will be landed and ask me to review this again. Thanks!
Attachment #8630956 - Flags: review?(borja.bugzilla)
Created attachment 8631441 [details] [review]
[gaia] mancas:bug1181469 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8630956 - Attachment is obsolete: true
(Assignee)

Comment 5

3 years ago
Comment on attachment 8631441 [details] [review]
[gaia] mancas:bug1181469 > mozilla-b2g:master

The patch is ready. Take a look when you want

Thanks :)
Attachment #8631441 - Flags: review?(borja.bugzilla)
Comment on attachment 8631441 [details] [review]
[gaia] mancas:bug1181469 > mozilla-b2g:master

Small comment to address, and wait for treeherder to merge! Thanks!
Attachment #8631441 - Flags: review?(borja.bugzilla) → review+
(Assignee)

Comment 7

3 years ago
Landed in master: https://github.com/mozilla-b2g/gaia/commit/4d640f800f26bb576e2920b4b554fdcf428a62ff
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
status-b2g-master: --- → fixed
You need to log in before you can comment on or make changes to this bug.