Closed Bug 1181469 Opened 10 years ago Closed 10 years ago

Eliminate fb prefix from service_extensions.js

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S2 (10Jul)
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: mancas, Assigned: mancas)

References

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 file, 1 obsolete file)

[gaia] mancas:bug1181469 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
borjasalguero
: review+
Details | Review
As part of the Meta Bug 1173013 that removes current FB integration from Contacts, we need to eliminate "fb-" prefixes from service_extensions.js
Status: NEW → ASSIGNED
No longer blocks: 1178646
Comment on attachment 8630956 [details] [review] [gaia] mancas:bug1181112 > mozilla-b2g:master Could you take a quick look at the patch? Thanks =)
Attachment #8630956 - Flags: review?(borja.bugzilla)
Target Milestone: --- → FxOS-S2 (10Jul)
Depends on: 1180135
Comment on attachment 8630956 [details] [review] [gaia] mancas:bug1181112 > mozilla-b2g:master This patch depends on https://bugzilla.mozilla.org/show_bug.cgi?id=1180135. Please rebase when the former patch will be landed and ask me to review this again. Thanks!
Attachment #8630956 - Flags: review?(borja.bugzilla)
Attachment #8630956 - Attachment is obsolete: true
Comment on attachment 8631441 [details] [review] [gaia] mancas:bug1181469 > mozilla-b2g:master The patch is ready. Take a look when you want Thanks :)
Attachment #8631441 - Flags: review?(borja.bugzilla)
Comment on attachment 8631441 [details] [review] [gaia] mancas:bug1181469 > mozilla-b2g:master Small comment to address, and wait for treeherder to merge! Thanks!
Attachment #8631441 - Flags: review?(borja.bugzilla) → review+
Landed in master: https://github.com/mozilla-b2g/gaia/commit/4d640f800f26bb576e2920b4b554fdcf428a62ff
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: