1178646 - Create basic 'open' activity not tied to contacts.js in a separate .html

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Manuel Casas Barrado [:mancas]]

When calling an 'open' activity, we dont need to load the whole app just for showing the contact details.
For solving this, we are going to create a separate.html which will handle this activity, loading just the dependencies that it needs.

In the near future, this will be the scaffolding to build more and advance features

Comment 1

[Manuel Casas Barrado [:mancas]]

Attachment: Patch

Comment 2

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8627618 [details] [review]
Patch

Hey Francisco, we have the details self-contained view, and the unit tests, can you take a look in order to give me feedback?

Thanks!

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8627618 [details] [review]
Patch

Great job Manu!! Just a few comments in Github. Overall, 2 main topics to focus on:
- Load *just* the code we need in every moment. Remove all dependencies that we dont need in boot.js, and move them to LazyLoading when needed. Some old dependencies can be removed as well. The less code we load, the faster we will be!
- Modify the manifest using the right filter by now. We will add VCARD in the near future, but this is out of the scope of this goal.

On the other hand the code works perfectly in my device, so we are definitely close to land this! Ask me to review this when ready. Thanks! Gracias!! :)

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8627618 [details] [review]
Patch

Great job, left some comments on gh, but definitely looking on the right direction.

Comment 5

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8627618 [details] [review]
Patch

Hey Borja, could you take a look at the PR when you get a chance?

Thanks! =)

Comment 6

[Borja Salguero [:borjasalguero]]

Comment on attachment 8627618 [details] [review]
Patch

\o/!!!! Now we are talking! Great job Manu!! R+ and hope to see this merged in gaia asap!

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8627618 [details] [review]
Patch

Great job Manuel,

just left tiny comment about naming, also, would you write a bit more about the documentation, like what is the philosophy, events that are sent and received to perform the actions, things to take into account, etc.

Thanks again!

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] mozilla-b2g:revert-30750-bug1178646 > mozilla-b2g:master

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] mancas:bug1178646 > mozilla-b2g:master

Comment 10

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8633333 [details] [review]
[gaia] mancas:bug1178646 > mozilla-b2g:master

I've revert the patch to write more about the documentation as Francisco suggested in comment 7. Same patch.

Comment 11

[Manuel Casas Barrado [:mancas]]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/f3bcc1a2bf5852e927d417e218c4d7f9025dd455 \o/

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

Manuel, this patch is using deprecated mozL10n.get API for bad reasons. 

You should never localize values to be stored in data model. Instead you should carry l10nId until you want to display it and then use data-l10n-id on the element.

See: https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices#Writing_APIs_that_operate_on_L10nIDs

Can you fix this please?

Comment 13

[Manuel Casas Barrado [:mancas]]

Of course Zibi. Let's create a follow-up to remove the uses of mozL10n.get

Comment 14

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Manuel Casas Barrado [:mancas] from comment #13)
> Of course Zibi. Let's create a follow-up to remove the uses of mozL10n.get

Thanks!