1181593 - When a call is put on hold by the other endpoint the phone number / contact info is not grayed out

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Gabriele Svelto [:gsvelto]]

Attachment: Screenshot with the issue highlighted

This is technically a regression from bug 1166635 but is fundamentally caused by the fact that the callscreen often changes the UI based on user action and not on state changes as described in bug 1082588. I've attached a screenshot highlighting problem.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1181593-held-call-fix > mozilla-b2g:master

Comment 2

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8638534 [details] [review]
[gaia] gabrielesvelto:bug-1181593-held-call-fix > mozilla-b2g:master

The change is fairly straightforward and gets rid of a lot of a fair chunk of fragile code while at the same time getting rid of the 'holding' and 'resuming' states which haven't existed since bug 1161403 landed.

Comment 3

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8638534 [details] [review]
[gaia] gabrielesvelto:bug-1181593-held-call-fix > mozilla-b2g:master

Looks good. Glad to see these cleanups.

Comment 4

[Gabriele Svelto [:gsvelto]]

Thanks for the quick review! I've pushed again to the PR w/o changes because the tests didn't seem to have been executed correctly and I don't want to merge without a green try run.

Comment 5

[Gabriele Svelto [:gsvelto]]

Merged to gaia/master 846b77ba65f4272810064f18a574209965ba2295

https://github.com/mozilla-b2g/gaia/commit/846b77ba65f4272810064f18a574209965ba2295