1082588 - [Dialer] Make the callscreen UI driven by state changes instead of actions

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Gabriele Svelto [:gsvelto]]

Attachment: [PATCH WIP] Change the callscreen appearance only in response to a change in the underlying state

+++ This bug was initially created as a clone of Bug #1081028 +++

The callscreen UI is often changed by certain actions (e.g. putting the call on hold) without waiting for the actual change to be reflected in the state. Bug 1081028 is a good example as we showed the "call held" UI after trying to put a CDMA call on hold, but since that's impossible the actual call would remain connected and yet be shown as held by the UI.

We should move all the code that updates the UI into the oncallschanged event handler because that's the only place where we get actual state changes. This should make the UI a lot more reliable, simplify testing and in general simplify code.

I'm attaching the WIP patch I had prepared for bug 1081028 as guidance for the future work here.

Comment 1

[Doug Sherk (:drs) (inactive)]

bug 1095601, bug 1095579, and bug 1094878 are all caused by us not making use of state changes to keep the UI accurate. Each of these bugs may require some additional tweaks in order for them to be complete, though, so we can't just dupe them all to each other.

An example of this problem is here:
https://github.com/mozilla-b2g/gaia/blob/master/apps/callscreen/js/calls_handler.js#L598

We should instead be checking the new state in the `onstatechange` callback and updating the UI appropriately. Note that we should not use the `onheld` callback since this will eventually be phased out.

Paco, since you're working on these 3 bugs, I'm needinfoing you to make sure that you see this. I have no specific questions or anything for you, but if you have any for me, please feel free to ask.

Comment 2

[Dylan Oliver [:doliver]]

Greg, in discussion with Inder last week he thought this bug might have been accidentally picked up by cafbot. Can you confirm, and if so, remove from the metabug?

Comment 3

[Greg Grisco]

(In reply to Dylan Oliver [:doliver] from comment #2)

Phil has a plan to keep this from blocking the metabug.  If the link comes back, he will try plan B.