1181644 - search suggestions in the awesome bar should include local search suggestions like all other access points

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P1)

Description

[Mike Connor [:mconnor]]

We're not using suggestions from local search history, unlike searchbar/about:home/about:newtab.  We should be consistent here and use the same model as all other access points.

It's a relatively simple fix to adjust this.  Repeating previous searches should be equally easy in the location bar as in all other access points.  We've just hardcoded to 0 for some reason that doesn't appear to be in the original bug.

Comment 1

[Drew Willcoxon :adw]

(In reply to Mike Connor [:mconnor] from comment #0)
> We've just hardcoded to 0 for some reason that doesn't appear to be in the
> original bug.

Because that was not what UX or any user story called for (bug 959564)...

Comment 2

[Kev Needham [:kev]]

Search History has the potential to add more entries to a potentially crowded results set in the dropdown. It's been discussed, but it's not something that was incorporated as a requirement for a first release given the other content types that intermingle with suggest results. Definitely something to look at as an enhancement.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

We discussed this with product and are aiming to do this in the 57 timeframe.

Comment 4

[Marco Bonardo [:mak]]

Bug 1359899 added a pref to do this.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Bug 1181644 - Include local search suggestions in the awesomebar like all other access points.

Review commit: https://reviewboard.mozilla.org/r/172212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172212/

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Discussed this at length with Javaun and we will go with 1 result for now.

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 8900765 [details]
Bug 1181644 - Include local search suggestions in the awesomebar like all other access points.

https://reviewboard.mozilla.org/r/172212/#review177488

Before landing, please check on Try for xpcshell, firefox-ui-functional and browser-chrome mochitests. While the code path is tested, we never ran the full harness with a positive value.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Indeed, I had started a try run already and a couple of test are failing. Updated patch coming up.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8900765 [details]
Bug 1181644 - Include local search suggestions in the awesomebar like all other access points.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172212/diff/1-2/

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

Latest try run looks green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=524549d6caea166057e026238dc2c67a02889d70

Comment 11

[Marco Bonardo [:mak]]

LGTM!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e20695873707
Include local search suggestions in the awesomebar like all other access points. r=mak

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e20695873707