1181715 - [B2G] Support for core dumps lost

Status: RESOLVED INVALID

(Firefox OS Graveyard :: General, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

"adb shell persist.debug.coredump all" still causes the kernel to enable core dumps and to create the appropriate folder, but the B2G processes do not generate a core dump nor let you capture the signal in a debugger.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Regression from bug 1173681 where the code was overwritten.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1181715.patch, v1

glandium: I think it was just an oversight from the regressing bug to drop this bit of code (previously reviewed in bug 1043112), as far as I know it wasn't causing any problems. Can you take a look and confirm for me? Thanks!

Comment 3

[Mike Hommey [:glandium] OoO until Dec 30]

AFAICT that patch from bug 1043112 never landed, so I don't see how bug 1173681 changed that. Are you sure you didn't patch it locally or something, and since the file moved, that patch is not applied anymore?

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Mike Hommey [:glandium] from comment #3)
> AFAICT that patch from bug 1043112 never landed, so I don't see how bug
> 1173681 changed that. Are you sure you didn't patch it locally or something,
> and since the file moved, that patch is not applied anymore?

This is very bizarre. It should have landed as part of bug 1043112 but you are correct -- the sheriffs only landed the git portions, not the hg. Commit history checks out. I couldn't have landed it myself at the time, as I only received commit access this spring... since then I have pushed many times to the tree though without that change going in (and nothing appears to be sitting quietly in my many patch queues).

Sometime in the last month (last time I core dumped a b2g process) it stopped working for me. Applying the "missing" change made it work again.

Maybe you are right and my tree is messed up somehow :|. That instills great confidence. Regardless, mea culpa, I'll clear the review and actually land the blasted thing. Thank you for pointing it out.