1181881 - Disabling Location is not user friendly - Android M

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

We can do better behavior. Video for the current behavior. Pretend that you set these settings several weeks ago.

https://www.youtube.com/watch?v=fvmVD62m8sk

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

We should detect that location is disabled on the system level and prompt the user to grant the permission. This will involve new strings, so tracking 42. Anthony, we need a design

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Shouldn't we be using system dialog UI for this? I've seen a lot of screenshots of what that looks like on M (http://4.bp.blogspot.com/-LCRPmN9Lx_E/VWc6aVDdMkI/AAAAAAAABpI/Kt5p6uEMK-U/s1600/cropped_runtime_permissions.png) and I think our copy should be simply "All Firefox to access your Location?".

Can we use the same location icon from the doorhanger, in the dialog?

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

We'll need to build against Android M SDK in order to use any of the features: bug 1183061.

@antlam: But we probably do not want to show the system UI overlay as soon as a website requests location, right?

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Renom for the same reason like bug 1190375: Before we can change to the new permission model we'll make sure that we build with the new SDK (meta bug 1183061) and set targetSdkVersion to 23. But then we'll have to make sure that we request all permissions at runtime. So there's a lot of groundwork needed before we can tackle this and it's unlikely that we'll uplift all this to 42.

At least Android will warn the user when they are revoking a permission from an app that does not support the new permission model.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

product wanted to decide when we want to support the new Android permission model (and I want that to be really really soon, but its going to be work and probably UX)

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Not working on this right now. But I'll come back to this when we start to work on meta bug 1212830 (Support for runtime permissions).

Comment 7

[:Margaret Leibovic]

We can track this wherever we decide to track bug 1212830, which is TBD.

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.