1182208 - [AccessFu][Android] enabled support for range slider control.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

At the moment adjusting values for input range is not working on android. We need to figure out what action/event needs to happen when we want to increase or decrease range input's value.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Add support for android scrolling and range accessibility actions.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8650143 [details] [diff] [review]
Add support for android scrolling and range accessibility actions.

Seems fine to me.

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8650143 [details] [diff] [review]
Add support for android scrolling and range accessibility actions.

Review of attachment 8650143 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just one comment to address

::: accessible/jsat/AccessFu.jsm
@@ +134,5 @@
>      Services.obs.addObserver(this, 'Accessibility:Focus', false);
>      Services.obs.addObserver(this, 'Accessibility:ActivateObject', false);
>      Services.obs.addObserver(this, 'Accessibility:LongPress', false);
> +    Services.obs.addObserver(this, 'Accessibility:ScrollForward', false);
> +    Services.obs.addObserver(this, 'Accessibility:ScrollBackward', false);

These observers also need to removed in _disable.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/581329d6602b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/581329d6602b