Closed
Bug 1182464
Opened 9 years ago
Closed 9 years ago
DB changes to support the auto starring investigation
Categories
(Tree Management :: Treeherder: Data Ingestion, defect, P2)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mdoglio, Assigned: mdoglio)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
We need to to store some info specific to test failures and crashes. This bug is to track both the schema alteration and the data ingestion.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mdoglio
Comment 1•9 years ago
|
||
The error summary files are now being generated, so there is data to collect here.
Comment 2•9 years ago
|
||
(In reply to James Graham [:jgraham] from comment #1)
> The error summary files are now being generated, so there is data to collect
> here.
See bug 1185453 comment 14 for links to example error summary files (though the links as-is currently returns no content, not sure why).
Comment 3•9 years ago
|
||
Jobs that succeed produce empty error summary files that are, unfortunately, still uploaded. It's only jobs with an error where the files are expected to have any content.
Comment 4•9 years ago
|
||
Ah makes more sense thank you :-)
From IRC: for jobs with failures there is one json line per failure - example summary:
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/mozilla-inbound/sha512/10d61f98f31ce4a6629d8650a367916a9674e8f772d6ea0eb5aeff2f5fc5617156e61bc72aa9a234dc55688d67fdca1526b7b72fd963d998e815c84e82f764df
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8646278 -
Flags: feedback?(emorley)
Comment 6•9 years ago
|
||
Comment on attachment 8646278 [details] [review]
PR 853
Looks good at a first glance! :-)
Attachment #8646278 -
Flags: feedback?(emorley)
Assignee | ||
Comment 7•9 years ago
|
||
Thanks :emorley, this is now ready for a review.
Assignee | ||
Updated•9 years ago
|
Attachment #8646278 -
Flags: review?(james)
Attachment #8646278 -
Flags: review?(emorley)
Comment 8•9 years ago
|
||
Comment on attachment 8646278 [details] [review]
PR 853
r+, but left comments :-)
Attachment #8646278 -
Flags: review?(emorley) → review+
Updated•9 years ago
|
Priority: -- → P2
Comment 9•9 years ago
|
||
Comment on attachment 8646278 [details] [review]
PR 853
Just needs a few changes in the error summary storage.
Attachment #8646278 -
Flags: review?(james) → review-
Assignee | ||
Updated•9 years ago
|
Attachment #8646278 -
Flags: review- → review?(james)
Updated•9 years ago
|
Attachment #8646278 -
Flags: review?(james) → review+
Comment 10•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/86e0841024ec1ff9a355f26cea021329124c3ccf
Bug 1182464 - Add BigAutoField to handle big integers as primary keys
https://github.com/mozilla/treeherder/commit/a92fdd46efd5b4f4f45b85931e17f4c4615e0215
Bug 1182464 - Add ORM classes, sql and migration for the autostarring tables
fixup! Bug 1182464 - Add Failure class, sql and migration
https://github.com/mozilla/treeherder/commit/c38d21813e5ae203bc1730a8964d8f3fd0b4a97a
Bug 1182464 - update mozlog version
https://github.com/mozilla/treeherder/commit/5a796eb969745d10d39b180193ebe5b8e5318bd0
Bug 1182464 - Add store_error_summary django command
https://github.com/mozilla/treeherder/commit/ee12c00a03832451ff32a7eb2c434252b550f63c
Bug 1182464 - Add celery task to store the error summary
https://github.com/mozilla/treeherder/commit/79fc062a296a93e8210251ab396993ef857c684e
Bug 1182464 - move test_parse_log command in the log_parser folder
Comment 11•9 years ago
|
||
The changes in comment 10 are deployed on stage, but not prod.
Before we push this to prod I think we need to add a limit to the number of failure lines we'll process for any one job, to avoid issues like we saw in bug 1152681.
We may wish to do a hitfix branch for a prod deploy for bug 1201913 before then, since this + the testing of the other UI changes on stage realistically won't be done until Monday/Tuesday.
Assignee | ||
Comment 12•9 years ago
|
||
Attachment #8657804 -
Flags: review?(james)
Attachment #8657804 -
Flags: review?(emorley)
Comment 13•9 years ago
|
||
Comment on attachment 8657804 [details] [review]
PR 944
Cancelling review for now - will take another look when the PR is updated :-)
Attachment #8657804 -
Flags: review?(emorley)
Assignee | ||
Updated•9 years ago
|
Attachment #8657804 -
Flags: review?(emorley)
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8657804 [details] [review]
PR 944
I update attachment 8657804 [details] [review] according to the feedback received. Thanks for your patience :-)
Comment 15•9 years ago
|
||
Comment on attachment 8657804 [details] [review]
PR 944
r=me with the nits fixed + James being happy with the model parts :-)
Attachment #8657804 -
Flags: review?(emorley) → review+
Updated•9 years ago
|
Attachment #8657804 -
Flags: review?(james) → review+
Comment 16•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/b78d6bbf0b9593ee204acca9ebaa2f81130297ea
Bug 1182464 - Make the failure_line signature a TextField.
I also removed a limit on the length of `message` because it didn't make sense.
https://github.com/mozilla/treeherder/commit/420a0323179c424c2ccc85cc91f3e8344966ba97
Bug 1182464 - Make `score` a DecimalField
https://github.com/mozilla/treeherder/commit/6ac54cb95ff67a811ba291c1d3a8e3b4b64acf7f
Bug 1182464 - Add a limit to the maximum number of failure lines
https://github.com/mozilla/treeherder/commit/a5548c7bfeeccafe6395f606c99f48f4c2002f06
Bug 1182464 - Keep track of failure lines truncation
The truncation point is indicated by a special line with action='truncated'.
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 17•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/1e287efb78ac8ee90a29bc1dde4ed8789cdeddca
Bug 1182464 - Add new action choice to the migrations file
You need to log in
before you can comment on or make changes to this bug.
Description
•