1182516 - Add Chaos Mode Pref and/or Environment Variable

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Benoit Girard (:BenWa)]

I'd like to have OrangeHunter trigger ChoasMode.

Generally environment variables are easier to deal with from the command line and can be triggered very early in the startup sequence. Preferences are often accidentally flipped and forgotten. But I could be convinced to use a preference.

Comment 1

[(no longer active)]

Doesn't bug 1164218 give you what you want here?

Comment 2

[Benoit Girard (:BenWa)]

Very quick scan at the bug:
- It's only for reftest
- It's on a per test basis

I want to be able to run any test suite under chaos mode. Unless I'm missing something?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

(In reply to Benoit Girard (:BenWa) from comment #2)
> - It's only for reftest

It's for mochitests too.

Comment 4

[(no longer active)]

My point is that running the entire test suite under Chaos Mode will just give you millions of oranges, so it doesn't seem useful to run all tests under chaos mode right now, and bug 1164218 should give you what we want for a single reftest/mochitest.

Comment 5

[Benoit Girard (:BenWa)]

Attachment: MozReview Request: Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc

Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=ehsan

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Ehsan Akhgari (not reviewing patches, not reading bugmail, needinfo? me!) from comment #4)
> My point is that running the entire test suite under Chaos Mode will just
> give you millions of oranges, so it doesn't seem useful to run all tests
> under chaos mode right now,

Not for most people, but it will be useful if we want to try to fix those oranges, which I think we do.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://reviewboard.mozilla.org/r/13159/#review11743

::: toolkit/xre/nsAppRunner.cpp:3126
(Diff revision 1)
> +    ChaosMode::SetChaosFeature(mozilla::Any);

I think it would be useful to parse MOZ_CHAOSMODE as an integer and set those features.

Comment 8

[(no longer active)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #6)
> (In reply to Ehsan Akhgari (not reviewing patches, not reading bugmail,
> needinfo? me!) from comment #4)
> > My point is that running the entire test suite under Chaos Mode will just
> > give you millions of oranges, so it doesn't seem useful to run all tests
> > under chaos mode right now,
> 
> Not for most people, but it will be useful if we want to try to fix those
> oranges, which I think we do.

Sold!

Comment 9

[Benoit Girard (:BenWa)]

Comment on attachment 8632980 [details]
MozReview Request: Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc

Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8632980 [details]
MozReview Request: Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc

https://reviewboard.mozilla.org/r/13159/#review11905

Ship It!

Comment 11

[Benoit Girard (:BenWa)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/fe2800b80350314ab5cdab826f69f2837a4c3fd6
changeset:  fe2800b80350314ab5cdab826f69f2837a4c3fd6
user:       Benoit Girard <[e-mail]>
date:       Tue Jul 14 17:29:23 2015 -0400
description:
Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc

Comment 12

[Benoit Girard (:BenWa)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f54e7f247cf2586f5e51b04f133f87f4eafc7816
changeset:  f54e7f247cf2586f5e51b04f133f87f4eafc7816
user:       Benoit Girard <[e-mail]>
date:       Wed Jul 15 18:08:25 2015 -0400
description:
Bug 1182516 - Fix mid-air conflict with 3fd2ab6cb762 on a CLOSED TREE. r=bustage

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fe2800b80350
https://hg.mozilla.org/mozilla-central/rev/f54e7f247cf2