Add Chaos Mode Pref and/or Environment Variable

RESOLVED FIXED in Firefox 42

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

(Blocks 1 bug)

unspecified
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
I'd like to have OrangeHunter trigger ChoasMode.

Generally environment variables are easier to deal with from the command line and can be triggered very early in the startup sequence. Preferences are often accidentally flipped and forgotten. But I could be convinced to use a preference.

Comment 1

4 years ago
Doesn't bug 1164218 give you what you want here?
Flags: needinfo?(bgirard)
Assignee

Comment 2

4 years ago
Very quick scan at the bug:
- It's only for reftest
- It's on a per test basis

I want to be able to run any test suite under chaos mode. Unless I'm missing something?
Flags: needinfo?(bgirard)
(In reply to Benoit Girard (:BenWa) from comment #2)
> - It's only for reftest

It's for mochitests too.

Comment 4

4 years ago
My point is that running the entire test suite under Chaos Mode will just give you millions of oranges, so it doesn't seem useful to run all tests under chaos mode right now, and bug 1164218 should give you what we want for a single reftest/mochitest.
Assignee

Comment 5

4 years ago
Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=ehsan
(In reply to Ehsan Akhgari (not reviewing patches, not reading bugmail, needinfo? me!) from comment #4)
> My point is that running the entire test suite under Chaos Mode will just
> give you millions of oranges, so it doesn't seem useful to run all tests
> under chaos mode right now,

Not for most people, but it will be useful if we want to try to fix those oranges, which I think we do.
https://reviewboard.mozilla.org/r/13159/#review11743

::: toolkit/xre/nsAppRunner.cpp:3126
(Diff revision 1)
> +    ChaosMode::SetChaosFeature(mozilla::Any);

I think it would be useful to parse MOZ_CHAOSMODE as an integer and set those features.

Comment 8

4 years ago
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #6)
> (In reply to Ehsan Akhgari (not reviewing patches, not reading bugmail,
> needinfo? me!) from comment #4)
> > My point is that running the entire test suite under Chaos Mode will just
> > give you millions of oranges, so it doesn't seem useful to run all tests
> > under chaos mode right now,
> 
> Not for most people, but it will be useful if we want to try to fix those
> oranges, which I think we do.

Sold!
Assignee

Updated

4 years ago
Attachment #8632980 - Attachment description: MozReview Request: Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=ehsan → MozReview Request: Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc
Attachment #8632980 - Flags: review?(roc)
Assignee

Comment 9

4 years ago
Comment on attachment 8632980 [details]
MozReview Request: Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc

Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc
Comment on attachment 8632980 [details]
MozReview Request: Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc

https://reviewboard.mozilla.org/r/13159/#review11905

Ship It!
Attachment #8632980 - Flags: review?(roc) → review+
Assignee

Comment 11

4 years ago
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/fe2800b80350314ab5cdab826f69f2837a4c3fd6
changeset:  fe2800b80350314ab5cdab826f69f2837a4c3fd6
user:       Benoit Girard <b56girard@gmail.com>
date:       Tue Jul 14 17:29:23 2015 -0400
description:
Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc
Assignee

Updated

4 years ago
Assignee: nobody → bgirard
Assignee

Comment 12

4 years ago
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f54e7f247cf2586f5e51b04f133f87f4eafc7816
changeset:  f54e7f247cf2586f5e51b04f133f87f4eafc7816
user:       Benoit Girard <b56girard@gmail.com>
date:       Wed Jul 15 18:08:25 2015 -0400
description:
Bug 1182516 - Fix mid-air conflict with 3fd2ab6cb762 on a CLOSED TREE. r=bustage
https://hg.mozilla.org/mozilla-central/rev/fe2800b80350
https://hg.mozilla.org/mozilla-central/rev/f54e7f247cf2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.