Closed
Bug 1182647
Opened 10 years ago
Closed 10 years ago
Move setGCCallback from shell/js.cpp to TestingFunctions.cpp
Categories
(Core :: JavaScript: GC, enhancement)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: jruderman, Assigned: sfink)
References
Details
Attachments
(1 file)
|
11.38 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Bug 1117768 added setGCCallback() to js/shell.cpp. It should be moved to TestingFunctions.cpp, so it can also be called from browser-based fuzz tests.
|
||
Comment 1•10 years ago
|
||
Here's the patch (it's trivial). If you want to keep ownership on this code, I am fine with inverting the author and reviewer fields, after you've r+ it (and if that's not too nasty).
Attachment #8634878 -
Flags: review?(sphink)
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8634878 [details] [diff] [review]
move.setgccallback.testing.patch
Review of attachment 8634878 [details] [diff] [review]:
-----------------------------------------------------------------
So you're saying that as long as I don't tell you to do anything different, you're taking ownership of this code?
\o/ \o/ \o/
(sucker!)
Attachment #8634878 -
Flags: review?(sphink) → review+
|
|
||
Comment 3•10 years ago
|
||
Logic error: syllogism detected, line 1. ;)
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•