Closed Bug 1182647 Opened 5 years ago Closed 5 years ago

Move setGCCallback from shell/js.cpp to TestingFunctions.cpp

Categories

(Core :: JavaScript: GC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jruderman, Assigned: sfink)

References

Details

Attachments

(1 file)

Bug 1117768 added setGCCallback() to js/shell.cpp. It should be moved to TestingFunctions.cpp, so it can also be called from browser-based fuzz tests.
Here's the patch (it's trivial). If you want to keep ownership on this code, I am fine with inverting the author and reviewer fields, after you've r+ it (and if that's not too nasty).
Attachment #8634878 - Flags: review?(sphink)
Comment on attachment 8634878 [details] [diff] [review]
move.setgccallback.testing.patch

Review of attachment 8634878 [details] [diff] [review]:
-----------------------------------------------------------------

So you're saying that as long as I don't tell you to do anything different, you're taking ownership of this code?

\o/  \o/  \o/

(sucker!)
Attachment #8634878 - Flags: review?(sphink) → review+
Logic error: syllogism detected, line 1. ;)
https://hg.mozilla.org/mozilla-central/rev/36c0d857aa86
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.