Closed Bug 1182945 Opened 5 years ago Closed 5 years ago
Temporarily disabled Web
M MSE tests
The new MSE doesn't support webm at present. In order to be able to enable it by default, we must first disable webm mochitest and webref tests.
5 years ago
Attachment #8632740 - Flags: review?(ajones) → review+
Comment on attachment 8635094 [details] [diff] [review] P2. Disable webm mse web-platforms tests. >@@ -1,20 +1,34 @@ > [mediasource-buffered.html] > type: testharness > prefs: [media.mediasource.enabled:true, media.mediasource.whitelist:false] >+ disabled: >+ if (os == "win") and (version == "5.1.2600"): https://bugzilla.mozilla.org/show_bug.cgi?id=1182945 Rather than just linking to the bug that disabled the test, the idea is that the bug referenced here describes the state of the test and tracks fixing it. In this case, perhaps there's not much point having more than a bug to track webm support, but can you comment in this bug or the checkin message please on the why this test needed to be disabled? Was a particular subtest throwing intermittent exceptions, or timing out? >+++ b/testing/web-platform/meta/media-source/mediasource-duration.html.ini >@@ -9,9 +9,10 @@ > > [Test endOfStream completes previous seek to truncated duration] > disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1148224 > > [Test setting same duration multiple times does not fire duplicate durationchange] > expected: > if os == "linux": FAIL > if (os == "win") and (version == "5.1.2600"): FAIL >+ if (os == "win") and (version != "5.1.2600"): FAIL This one seems odd. SEGMENT_INFO_LIST has mp4 first, so I would have thought that webm was not involved, unless codecs="mp4a.40.2,avc1.4d400d" is not supported? >+++ b/testing/web-platform/meta/media-source/mediasource-sourcebuffer-mode.html.ini >@@ -1,9 +1,33 @@ > [mediasource-sourcebuffer-mode.html] > type: testharness > prefs: [media.mediasource.enabled:true, media.mediasource.whitelist:false] > [Test setting SourceBuffer.mode] >- expected: FAIL >+ expected: >+ if (os == "win") and (version != "5.1.2600"): PASS >+ FAIL > > [Test setting SourceBuffer.mode and SourceBuffer.timestampOffset while parsing media segment.] >- expected: FAIL >+ expected: >+ if (os == "win") and (version != "5.1.2600"): PASS >+ FAIL Similarly, I don't know why these would now pass. But perhaps some state has changed from previous tests.
Attachment #8635094 - Flags: review?(karlt) → review+
You need to log in before you can comment on or make changes to this bug.