Closed Bug 1182962 Opened 4 years ago Closed 4 years ago

Use nsTHashTable::Iterator in gfx/

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(3 files)

Because iterators are so much nicer than enumerate functions.

There are fourteen occurrences of EnumerateEntries() in gfx/ to be dealt with.
Attachment #8633263 - Flags: review?(jfkthame) → review+
Attachment #8633264 - Flags: review?(jfkthame) → review+
Comment on attachment 8633265 [details] [diff] [review]
(part 3) - Use nsTHashtable::Iterator in gfxPlatformFontList

Review of attachment 8633265 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine, but I'm going to bounce it to jdaggett as I think he's currently much more familiar with this code than I am.
Attachment #8633265 - Flags: review?(jfkthame) → review?(jdaggett)
Comment on attachment 8633265 [details] [diff] [review]
(part 3) - Use nsTHashtable::Iterator in gfxPlatformFontList

Review of attachment 8633265 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, this makes the code so much easier to read... r+++
Attachment #8633265 - Flags: review?(jdaggett) → review+
You need to log in before you can comment on or make changes to this bug.