1182962 - Use nsTHashTable::Iterator in gfx/

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are fourteen occurrences of EnumerateEntries() in gfx/ to be dealt with.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

All of which are in font-related code:

http://mxr.mozilla.org/mozilla-central/ident?i=EnumerateEntries&tree=mozilla-central&filter=gfx%2F*

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Use nsTHashtable::Iterator in gfxUserFontSet

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Use nsTHashtable::Iterator in gfxFont

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Use nsTHashtable::Iterator in gfxPlatformFontList

Comment 5

[Jonathan Kew [:jfkthame]]

Comment on attachment 8633265 [details] [diff] [review]
(part 3) - Use nsTHashtable::Iterator in gfxPlatformFontList

Review of attachment 8633265 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine, but I'm going to bounce it to jdaggett as I think he's currently much more familiar with this code than I am.

Comment 6

[John Daggett (:jtd)]

Comment on attachment 8633265 [details] [diff] [review]
(part 3) - Use nsTHashtable::Iterator in gfxPlatformFontList

Review of attachment 8633265 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, this makes the code so much easier to read... r+++

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e043784e6de8
https://hg.mozilla.org/integration/mozilla-inbound/rev/900b78faf546
https://hg.mozilla.org/integration/mozilla-inbound/rev/8948b9bf4c9d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e043784e6de8
https://hg.mozilla.org/mozilla-central/rev/900b78faf546
https://hg.mozilla.org/mozilla-central/rev/8948b9bf4c9d