1181443 - (replace-nsTHashtable-Enumerate) Replace nsTHashtable::EnumerateEntries() with an iterator

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

Iterators are *so* much nicer than Enumerate()-style functions -- no need for a separate function, no need to bundle up relevant local variables into a |void*| closure, etc.

Currently there are about 168 calls to nsTHashtable::EnumerateEntries(), so this is going to take a while.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Use nsTHashtable::Iterator in nsCheapSet

nsCheapSet is used little enough that I didn't bother creating an iterator for
it.

I removed the dependency on PLDHashOperator by introducing nsCheapSetOperator,
which is equivalent.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Use nsTHashtable::Iterator in TestHashtables.cpp

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Remove nsTHashtable::EnumerateEntries(), which is no longer used

This is not yet able to land -- bug 1182961 is the main remaining obstacle --
but I wrote it in preparation.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9dc6406a0f4c
https://hg.mozilla.org/integration/mozilla-inbound/rev/be27e653d819

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9dc6406a0f4c
https://hg.mozilla.org/mozilla-central/rev/be27e653d819

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04a196339ca4

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/04a196339ca4

Comment 8

[Nicholas Nethercote [inactive]]

Part 3 backed out because I need to back out bug 1182961's patches:

https://hg.mozilla.org/integration/mozilla-inbound/rev/11f2aec8187f

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/65d0876d5a2c

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0006b20bdca9

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0006b20bdca9