Closed Bug 1181443 (replace-nsTHashtable-Enumerate) Opened 4 years ago Closed 4 years ago

Replace nsTHashtable::EnumerateEntries() with an iterator

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(3 files)

Iterators are *so* much nicer than Enumerate()-style functions -- no need for a separate function, no need to bundle up relevant local variables into a |void*| closure, etc.

Currently there are about 168 calls to nsTHashtable::EnumerateEntries(), so this is going to take a while.
Alias: replace-nsTHashtable-Enumerate
Depends on: 1181445
Depends on: 1182408
Depends on: 1182725
Depends on: 1182958
Depends on: 1182959
Depends on: 1182960
Depends on: 1182961
Depends on: 1182962
Depends on: 1182963
Depends on: 1182964
Depends on: 1182966
Depends on: 1182969
Depends on: 1182973
Depends on: 1182975
Depends on: 1182976
Depends on: 1182977
Depends on: 1182978
Depends on: 1182979
Depends on: 1182980
Depends on: 1182981
Depends on: 1183141
Depends on: 1183158
No longer depends on: 1182725
Depends on: 1184432
No longer depends on: 1184432
nsCheapSet is used little enough that I didn't bother creating an iterator for
it.

I removed the dependency on PLDHashOperator by introducing nsCheapSetOperator,
which is equivalent.
Attachment #8637782 - Flags: review?(nfroyd)
This is not yet able to land -- bug 1182961 is the main remaining obstacle --
but I wrote it in preparation.
Attachment #8637788 - Flags: review?(nfroyd)
Attachment #8637782 - Flags: review?(nfroyd) → review+
Attachment #8637783 - Flags: review?(nfroyd) → review+
Attachment #8637788 - Flags: review?(nfroyd) → review+
Keywords: leave-open
Attachment #8637782 - Flags: checkin+
Attachment #8637783 - Flags: checkin+
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/04a196339ca4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Part 3 backed out because I need to back out bug 1182961's patches:

https://hg.mozilla.org/integration/mozilla-inbound/rev/11f2aec8187f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/0006b20bdca9
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.