1182969 - Use nsTHashTable::Iterator in accessible/

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are two occurrences of EnumerateEntries() in accessible/ to be dealt with.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Use nsTHashTable::Iterator in accessible/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: |diff -w| version

Here's a |diff -w| version of the patch that is a lot easier to read.

Comment 3

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8637654 [details] [diff] [review]
Use nsTHashTable::Iterator in accessible/

thanks, I'm swamped with a11y e10s so don't have time for cleaning stuff up :/

>   // Process rendered text change notifications.
>-  mTextHash.EnumerateEntries(TextEnumerator, mDocument);
>+  ProcessRenderedTextChangeNotifications();
>   mTextHash.Clear();


it might make more sense for that to be part of ProcessRenderedText, but up to you.

Comment 4

[Nicholas Nethercote [inactive]]

Thank you for the fast review.

> it might make more sense for that to be part of ProcessRenderedText, but up
> to you.

In this case I left it as a separate function because the loop body was large, but I'm happy to inline it and will do so.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51afd4c6a44e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/51afd4c6a44e