1182978 - Use nsTHashTable::Iterator in dom/smil/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are 14 occurrences of EnumerateEntries() in dom/smil/ to be dealt with.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Use nsTHashtable::Iterator in nsSMILAnimationController

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Use nsTHashtable::Iterator in nsSMILAnimationController

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Use nsTHashtable::Iterator in nsSMILAnimationController

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Use nsTHashtable::Iterator in nsSMILAnimationController

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: (part 5) - Use nsTHashtable::Iterator in nsSMILTimedElement

Comment 6

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8637032 [details] [diff] [review]
(part 2) - Use nsTHashtable::Iterator in nsSMILAnimationController

Review of attachment 8637032 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/smil/nsSMILAnimationController.cpp
@@ +377,5 @@
> +  for (auto iter = mAnimationElementTable.Iter(); !iter.Done(); iter.Next()) {
> +    SVGAnimationElement* animElem = iter.Get()->GetKey();
> +    if (!animElem) {
> +      continue;
> +    }

I think we could probably skip the null check here. I notice nsSMILAnimationController::AddStyleUpdate and nsSMILAnimationController::RewindAnimation do that. But leaving this patch as a purely mechanical conversion of the existing code is fine too.

Comment 7

[Nicholas Nethercote [inactive]]

Thank you for the fast reviews.

> I think we could probably skip the null check here.

Ok. The existing code was *very* conservative about argument checking in some places, so I'm happy to undo that.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a7c0feb7bb6
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c58983492ec
https://hg.mozilla.org/integration/mozilla-inbound/rev/2222bb624dbe
https://hg.mozilla.org/integration/mozilla-inbound/rev/da0f28a2c1e3
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8fe6eb918d

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a7c0feb7bb6
https://hg.mozilla.org/mozilla-central/rev/2c58983492ec
https://hg.mozilla.org/mozilla-central/rev/2222bb624dbe
https://hg.mozilla.org/mozilla-central/rev/da0f28a2c1e3
https://hg.mozilla.org/mozilla-central/rev/8d8fe6eb918d