1182979 - Use nsTHashTable::Iterator in dom/{plugins,media}/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are seven occurrences of EnumerateEntries() in dom/{plugins,media}/ to be dealt with.

Comment 1

[Nicholas Nethercote [inactive]]

ehsan, please note that poiru already assigned this one to himself. Hopefully he hasn't already done the the WebAudio changes. We don't want to waste time doing work multiple times. Thanks!

Comment 2

[Biru [:poiru]]

Attachment: Part 1: Use nsTHashtable::Iterator in PluginInstanceChild

Comment 3

[Biru [:poiru]]

Attachment: Part 2: Use nsTHashtable::Iterator in PluginScriptableObjectChild

Comment 4

[Biru [:poiru]]

Attachment: Part 3: Use nsTHashtable::Iterator in GMPTimerParent

Comment 5

[Biru [:poiru]]

Attachment: Part 4: Use nsTHashtable::Iterator in MediaShutdownManager

Comment 6

[Biru [:poiru]]

(In reply to Nicholas Nethercote [:njn] from comment #1)
> ehsan, please note that poiru already assigned this one to himself.
> Hopefully he hasn't already done the the WebAudio changes.

I didn't so clearing Ehsan's ni?.

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 8634799 [details] [diff] [review]
Part 1: Use nsTHashtable::Iterator in PluginInstanceChild

Review of attachment 8634799 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like to see this code moved into a helper we call from here similar to the enumerate calls.

::: dom/plugins/ipc/PluginInstanceChild.cpp
@@ +3980,5 @@
> +        NPObject* o = e->GetKey();
> +        if (!e->mDeleted) {
> +            e->mDeleted = true;
> +
> +    #ifdef NS_BUILD_REFCNT_LOGGING

nit - this shouldn't be indented like this.

Comment 8

[Biru [:poiru]]

Attachment: Part 1: Use nsTHashtable::Iterator in PluginInstanceChild

Comment 9

[Jim Mathies [:jimm]]

Comment on attachment 8634818 [details] [diff] [review]
Part 1: Use nsTHashtable::Iterator in PluginInstanceChild

Review of attachment 8634818 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8634802 [details] [diff] [review]
Part 3: Use nsTHashtable::Iterator in GMPTimerParent

Review of attachment 8634802 [details] [diff] [review]:
-----------------------------------------------------------------

There are insufficient letters in the word "nice" to adequately express how much nicer this is. Nice!

Comment 11

[Nicholas Nethercote [inactive]]

niiiiiiiiiiiiiiiiice

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9755f46ef61d
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bcdfe1b266e
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f11db99d95
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6462de549bd

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9755f46ef61d
https://hg.mozilla.org/mozilla-central/rev/3bcdfe1b266e
https://hg.mozilla.org/mozilla-central/rev/76f11db99d95
https://hg.mozilla.org/mozilla-central/rev/b6462de549bd