1183068 - TopSitesCursorWrapper does not override abstract method setExtras(Bundle) in Cursor

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

TopSitesCursorWrapper implements the Cursor interface and Android M added a new method: setExtras(Bundle).

From the preview SDK docs: "Sets a Bundle that will be returned by getExtras()."

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1183068-cursor-interface.patch

Comment 2

[Martyn Haigh (:mhaigh)]

Comment on attachment 8642441 [details] [diff] [review]
1183068-cursor-interface.patch

Review of attachment 8642441 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/db/TopSitesCursorWrapper.java
@@ +485,5 @@
>      public Bundle getExtras() {
>          throw new UnsupportedOperationException();
>      }
>  
> +    // @Override - Method has been introduced in Android M. Add @Override annotation as soon as we are building with the M SDK

Can we add a bug and add that bug number to this TODO?

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Martyn Haigh (:mhaigh) from comment #2)
> Can we add a bug and add that bug number to this TODO?

Sure! :) I wanted to avoid creating the bug before landing this.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

url:        https://hg.mozilla.org/integration/fx-team/rev/076372b0b6808dfff4fa1a544c465cbd39d5e56a
changeset:  076372b0b6808dfff4fa1a544c465cbd39d5e56a
user:       Sebastian Kaspari <[e-mail]>
date:       Tue Aug 11 11:54:38 2015 +0200
description:
Bug 1183068 - TopSitesCursorWrapper: Add new interface method setExtras(Bundle). r=mhaigh

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/076372b0b680