Closed Bug 1183068 Opened 6 years ago Closed 6 years ago

TopSitesCursorWrapper does not override abstract method setExtras(Bundle) in Cursor

Categories

(Firefox for Android Graveyard :: General, defect)

42 Branch
All
Android
defect
Not set
normal

Tracking

(firefox42 affected, firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox42 --- affected
firefox43 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(1 file)

TopSitesCursorWrapper implements the Cursor interface and Android M added a new method: setExtras(Bundle).

From the preview SDK docs: "Sets a Bundle that will be returned by getExtras()."
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment on attachment 8642441 [details] [diff] [review]
1183068-cursor-interface.patch

Review of attachment 8642441 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/db/TopSitesCursorWrapper.java
@@ +485,5 @@
>      public Bundle getExtras() {
>          throw new UnsupportedOperationException();
>      }
>  
> +    // @Override - Method has been introduced in Android M. Add @Override annotation as soon as we are building with the M SDK

Can we add a bug and add that bug number to this TODO?
Attachment #8642441 - Flags: review?(mhaigh) → review+
(In reply to Martyn Haigh (:mhaigh) from comment #2)
> Can we add a bug and add that bug number to this TODO?

Sure! :) I wanted to avoid creating the bug before landing this.
See Also: → 1193205
url:        https://hg.mozilla.org/integration/fx-team/rev/076372b0b6808dfff4fa1a544c465cbd39d5e56a
changeset:  076372b0b6808dfff4fa1a544c465cbd39d5e56a
user:       Sebastian Kaspari <s.kaspari@gmail.com>
date:       Tue Aug 11 11:54:38 2015 +0200
description:
Bug 1183068 - TopSitesCursorWrapper: Add new interface method setExtras(Bundle). r=mhaigh
https://hg.mozilla.org/mozilla-central/rev/076372b0b680
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.