1193205 - Add @override annotation to setExtras() in TopSitesCursorWrapper

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

setExtras() has been added to the Cursor interface in Android M. We added the method in bug 1183068 to be ready to build with the new SDK but we could not add the @Override annotation as long as we are not actually building with the SDK.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

We are now building with the new SDK. So this is a simple and easy thing to start with.

Comment 2

[Sanchit Nevgi]

Hi Sebastian! I would like to work on this bug. I've built Firefox for Desktop. Can I also build Firefox for Android (Fennec if I'm not wrong) from the same tree, how do I go about doing that? Thanks for the help :)

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sanchit Nevgi from comment #2)
> Hi Sebastian! I would like to work on this bug. I've built Firefox for
> Desktop. Can I also build Firefox for Android (Fennec if I'm not wrong) from
> the same tree, how do I go about doing that? Thanks for the help :)

Hi Sanchit! Yes, you can build Firefox for Android from the same tree. You just need to modify your mozconfig file or create a second one:
https://wiki.mozilla.org/Mobile/Fennec/Android#Preparing_a_Fennec_mozconfig

Make sure to run ./mach bootstrap and select "Firefox for Android" so that you have all prerequisites installed for building:
https://wiki.mozilla.org/Mobile/Fennec/Android#Getting_the_source

Comment 4

[Sanchit Nevgi]

Attachment: Added @Override annotation to setExtras() in TopSitesCursorWrapper

Comment 5

[Sanchit Nevgi]

Hey Sebastian! I've added the @Override annotation, please review the patch. Thanks! :)

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8675759 [details] [diff] [review]
Added @Override annotation to setExtras() in TopSitesCursorWrapper

Review of attachment 8675759 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thank you, Sanchit! :)

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5df0fa6d2d7

Comment 7

[Sanchit Nevgi]

Hey Sebastian! I'm wondering why the patch failed (on Android 2.3 and 4.3 I think). Do we need to submit it again?

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sanchit Nevgi from comment #7)
> Hey Sebastian! I'm wondering why the patch failed (on Android 2.3 and 4.3 I
> think). Do we need to submit it again?

Rc1 and Rc2 failed but the retry passed successfully (Click on +4). So everything is okay. :)

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/346ddee185b9

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/346ddee185b9