Add @override annotation to setExtras() in TopSitesCursorWrapper

RESOLVED FIXED in Firefox 45

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sebastian, Assigned: Sanchit Nevgi, Mentored)

Tracking

Trunk
Firefox 45
All
Android
Points:
---

Firefox Tracking Flags

(firefox43 affected, firefox45 fixed)

Details

(Whiteboard: [good first bug][lang=java])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
setExtras() has been added to the Cursor interface in Android M. We added the method in bug 1183068 to be ready to build with the new SDK but we could not add the @Override annotation as long as we are not actually building with the SDK.
(Reporter)

Updated

3 years ago
See Also: → bug 1183068
(Reporter)

Comment 1

3 years ago
We are now building with the new SDK. So this is a simple and easy thing to start with.
Mentor: s.kaspari
Whiteboard: [good first bug][lang=java]
(Assignee)

Comment 2

3 years ago
Hi Sebastian! I would like to work on this bug. I've built Firefox for Desktop. Can I also build Firefox for Android (Fennec if I'm not wrong) from the same tree, how do I go about doing that? Thanks for the help :)
Flags: needinfo?(s.kaspari)
(Reporter)

Comment 3

3 years ago
(In reply to Sanchit Nevgi from comment #2)
> Hi Sebastian! I would like to work on this bug. I've built Firefox for
> Desktop. Can I also build Firefox for Android (Fennec if I'm not wrong) from
> the same tree, how do I go about doing that? Thanks for the help :)

Hi Sanchit! Yes, you can build Firefox for Android from the same tree. You just need to modify your mozconfig file or create a second one:
https://wiki.mozilla.org/Mobile/Fennec/Android#Preparing_a_Fennec_mozconfig

Make sure to run ./mach bootstrap and select "Firefox for Android" so that you have all prerequisites installed for building:
https://wiki.mozilla.org/Mobile/Fennec/Android#Getting_the_source
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 4

3 years ago
Created attachment 8675759 [details] [diff] [review]
Added @Override annotation to setExtras() in TopSitesCursorWrapper
Attachment #8675759 - Flags: review?(s.kaspari)
(Assignee)

Comment 5

3 years ago
Hey Sebastian! I've added the @Override annotation, please review the patch. Thanks! :)
(Reporter)

Updated

3 years ago
Assignee: nobody → sanchit.nevgi
Status: NEW → ASSIGNED
(Reporter)

Comment 6

3 years ago
Comment on attachment 8675759 [details] [diff] [review]
Added @Override annotation to setExtras() in TopSitesCursorWrapper

Review of attachment 8675759 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thank you, Sanchit! :)

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5df0fa6d2d7
Attachment #8675759 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 7

3 years ago
Hey Sebastian! I'm wondering why the patch failed (on Android 2.3 and 4.3 I think). Do we need to submit it again?
Flags: needinfo?(s.kaspari)
(Reporter)

Comment 8

3 years ago
(In reply to Sanchit Nevgi from comment #7)
> Hey Sebastian! I'm wondering why the patch failed (on Android 2.3 and 4.3 I
> think). Do we need to submit it again?

Rc1 and Rc2 failed but the retry passed successfully (Click on +4). So everything is okay. :)
Flags: needinfo?(s.kaspari)
(Reporter)

Updated

3 years ago
Keywords: checkin-needed

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/346ddee185b9
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.