Closed Bug 118308 Opened 18 years ago Closed 11 years ago

NS_THEME_TEXTFIELD_CARET implementation (GTK)

Categories

(Core Graveyard :: Skinability, enhancement)

x86
Linux
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ian, Assigned: ventnor.bugzilla)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

This covers the GTK implementation of NS_THEME_TEXTFIELD_CARET. See bug 115761
for the XP side of this code (hooking nsITheme to PaintCaret).
Blocks: 39582, 117584
Blocks: 233462
Assignee: blizzard → p_ch
Blocks: 252242
Attached patch Patch (obsolete) — Splinter Review
This covers the XP part of hooking up nsCaret to the theme system. It also provides native drawing hooks for GTK so this will also fix bug 252242.
Assignee: p_ch → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #326234 - Flags: superreview?(roc)
Attachment #326234 - Flags: review?(roc)
+  nscoord caretWidth = 0;
+  if (aCaretHeight && mCaretAspectRatio) {
+    caretWidth = aCaretHeight * mCaretAspectRatio;
+  }

absolutely no point in avoid multiplications here. Just do 'caretWidth = ... * ..."

The native caret is not aware of the bidi state so this disables the bidi "hook" caret when the native caret is used. We probably shouldn't do that. The lowest-risk thing to do is to not use the native caret if GetHookRect() is nonempty.
Attached patch Patch 1.1Splinter Review
Fix comments.
Attachment #326234 - Attachment is obsolete: true
Attachment #326241 - Flags: superreview?(roc)
Attachment #326241 - Flags: review?(roc)
Attachment #326234 - Flags: superreview?(roc)
Attachment #326234 - Flags: review?(roc)
Attachment #326241 - Flags: superreview?(roc)
Attachment #326241 - Flags: superreview+
Attachment #326241 - Flags: review?(roc)
Attachment #326241 - Flags: review+
Keywords: checkin-needed
Checked in
ba1a2dc688af
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Core → Core Graveyard
Depends on: 483564
Blocks: 532717
You need to log in before you can comment on or make changes to this bug.