NS_THEME_TEXTFIELD_CARET implementation (GTK)

RESOLVED FIXED

Status

Core Graveyard
Skinability
--
enhancement
RESOLVED FIXED
16 years ago
4 years ago

People

(Reporter: Hixie (not reading bugmail), Assigned: Michael Ventnor)

Tracking

(Blocks: 1 bug)

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
This covers the GTK implementation of NS_THEME_TEXTFIELD_CARET. See bug 115761
for the XP side of this code (hooking nsITheme to PaintCaret).
(Reporter)

Updated

16 years ago
Blocks: 39582, 117584

Updated

14 years ago
Blocks: 233462
Assignee: blizzard → p_ch
(Assignee)

Updated

10 years ago
Blocks: 252242
(Assignee)

Comment 1

10 years ago
Created attachment 326234 [details] [diff] [review]
Patch

This covers the XP part of hooking up nsCaret to the theme system. It also provides native drawing hooks for GTK so this will also fix bug 252242.
Assignee: p_ch → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #326234 - Flags: superreview?(roc)
Attachment #326234 - Flags: review?(roc)
+  nscoord caretWidth = 0;
+  if (aCaretHeight && mCaretAspectRatio) {
+    caretWidth = aCaretHeight * mCaretAspectRatio;
+  }

absolutely no point in avoid multiplications here. Just do 'caretWidth = ... * ..."

The native caret is not aware of the bidi state so this disables the bidi "hook" caret when the native caret is used. We probably shouldn't do that. The lowest-risk thing to do is to not use the native caret if GetHookRect() is nonempty.
(Assignee)

Comment 3

10 years ago
Created attachment 326241 [details] [diff] [review]
Patch 1.1

Fix comments.
Attachment #326234 - Attachment is obsolete: true
Attachment #326241 - Flags: superreview?(roc)
Attachment #326241 - Flags: review?(roc)
Attachment #326234 - Flags: superreview?(roc)
Attachment #326234 - Flags: review?(roc)
Attachment #326241 - Flags: superreview?(roc)
Attachment #326241 - Flags: superreview+
Attachment #326241 - Flags: review?(roc)
Attachment #326241 - Flags: review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

10 years ago
Checked in
ba1a2dc688af
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Core → Core Graveyard
Depends on: 483564
You need to log in before you can comment on or make changes to this bug.