118308 - NS_THEME_TEXTFIELD_CARET implementation (GTK)

Status: RESOLVED FIXED

(Core Graveyard :: Skinability, enhancement)

Description

[Hixie (not reading bugmail)]

This covers the GTK implementation of NS_THEME_TEXTFIELD_CARET. See bug 115761
for the XP side of this code (hooking nsITheme to PaintCaret).

Comment 1

[Michael Ventnor]

Attachment: Patch

This covers the XP part of hooking up nsCaret to the theme system. It also provides native drawing hooks for GTK so this will also fix bug 252242.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+  nscoord caretWidth = 0;
+  if (aCaretHeight && mCaretAspectRatio) {
+    caretWidth = aCaretHeight * mCaretAspectRatio;
+  }

absolutely no point in avoid multiplications here. Just do 'caretWidth = ... * ..."

The native caret is not aware of the bidi state so this disables the bidi "hook" caret when the native caret is used. We probably shouldn't do that. The lowest-risk thing to do is to not use the native caret if GetHookRect() is nonempty.

Comment 3

[Michael Ventnor]

Attachment: Patch 1.1

Fix comments.

Comment 4

[Michael Ventnor]

Checked in
ba1a2dc688af