1183160 - [Bugzilla Lite] Testing the Log out to Bugzilla Lite

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Manel Rhaiem [:manel]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150513191138

Steps to reproduce:

* get the spark version on you device "flame"
* get marionette client 
* write a test for the log out


Actual results:

No test exist for the log out of Bugzilla Lite App


Expected results:

write a script, and run it

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mermi:logoutBzliteTest > mozilla-b2g:master

Comment 2

[Manel Rhaiem [:manel]]

Attachment: Testing the Log out to Bugzilla Lite

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] mermi:newLogoutBzlite > mozilla-b2g:master

Comment 4

[Manel Rhaiem [:manel]]

Attachment: Testing the Log out to Bugzilla Lite

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8643077 [details]
Testing the Log out to Bugzilla Lite

The test is on the right track. As bug 1180624 landed, git has fallen into a merge conflict. It think you're trying to add twice the same line. Then we need to rebase the patch and then resolve the conflicts.

I tested the patch locally (I added the code manually), and is_logged_out() is not passing. I also think the selectors can be more pointy. I left more details in the PR.

Thanks for this good start!

Comment 6

[Manel Rhaiem [:manel]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #5)
> Comment on attachment 8643077 [details]
> Testing the Log out to Bugzilla Lite
> 
> The test is on the right track. As bug 1180624 landed, git has fallen into a
> merge conflict. It think you're trying to add twice the same line. Then we
> need to rebase the patch and then resolve the conflicts.
> 
> I tested the patch locally (I added the code manually), and is_logged_out()
> is not passing. I also think the selectors can be more pointy. I left more
> details in the PR.
> 
> Thanks for this good start!

Thanks, I'll check the details in the PR :)

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8641047 [details] [review]
[gaia] mermi:newLogoutBzlite > mozilla-b2g:master

The test is easy to read and execute well on my device. The login test is not broken too.
I don't see any issue with the current code.

Good job! Thank you very much!

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8641047 [details] [review]
[gaia] mermi:newLogoutBzlite > mozilla-b2g:master

Asking John for a second review.

Comment 9

[Johan Lorenzo [:jlorenzo]]

I forgot one thing in the review. Could you modify the manifest file[1], so this test will be run in our jobs? Thanks!

[1] https://github.com/mermi/gaia/blob/newFillBug/tests/python/gaia-ui-tests/gaiatest/tests/functional/bzlite/manifest.ini

Comment 10

[Manel Rhaiem [:manel]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #9)
> I forgot one thing in the review. Could you modify the manifest file[1], so
> this test will be run in our jobs? Thanks!
> 
> [1]
> https://github.com/mermi/gaia/blob/newFillBug/tests/python/gaia-ui-tests/
> gaiatest/tests/functional/bzlite/manifest.ini

Right, I am doing it :)

Comment 11

[Johan Lorenzo [:jlorenzo]]

I can't land this test due to the gaia tree being closed (bug 1198172)

Comment 12

[Johan Lorenzo [:jlorenzo]]

Merged in master at: https://github.com/mozilla-b2g/gaia/commit/756428614f1c10d4687b654c372174c768f75f1b