1183174 - URL bar text isn't updated correctly when cancelling

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Bryan Munar (:bkmunar)]

STR:

1. go to a website
2. tap URL bar
3. click the x button, then the cancel button
4. URL bar isn't updated
5. repeat steps 2 - 4 and the URL bar is updated

I think the behavior should be to show the URL when cancelled, not show the empty search bar.

Comment 1

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8632893 [details] [review]
PR

Argh, looks like we were both working on the same bug. My fix here: https://github.com/thebnich/firefox-ios/commit/b27f45d321426b163d4fee2ee9074f9fa7a8aa37. I'll update that bug to just be about UI tests.

My fix just removed some of this logic altogether, including clearedText, as it wasn't obvious what this variable was for. I'd recommend that unless we can figure out what this clearedText is for...

Comment 4

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/732

Stealing from bkmunar since I already have the fix ready.

Comment 5

[Emily Toop (:fluffyemily)]

Comment on attachment 8633549 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/732

LGTM

Comment 6

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/33364216d4901348afc1a37ce2ffac5cd83fa5e5