1167216 - Regression: URL bar placeholder shifts to the left on focus

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

"Search or enter address" shifts to the left on URL bar focus all of a sudden

Comment 1

[Wesley Johnston (:wesj)]

This wasn't visible before because of 1137051. we'll track but its low priority.

Comment 2

[Wesley Johnston (:wesj)]

This is because we actually switch between a UILabel and a UITextField and the two don't overlap perfectly.

Comment 3

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 4

[Emily Toop (:fluffyemily)]

Have rewritten BrowserLocationView and URLBarView to use only one UITextField instead of a UILabel/UITextField combo

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8611139 [details] [review]
Pull request

Sorry, this slipped by my radar :( I put some comments in the PR. I think we need to make sure the spacing stays the same and the select-ed behavior isn't regressed either.

Comment 6

[Emily Toop (:fluffyemily)]

Attachment: Pull Request

Updated as requested. I've used a much better strategy that uses autolayout for the display of the reader view button and the lock icon.

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 8620720 [details] [review]
Pull Request

Looks good! Thanks, I think this is a good move for the way this is built.