Closed Bug 118322 Opened 23 years ago Closed 23 years ago

Trunk Crash while launching preferences [@ nsOutlinerContentView::Select]

Categories

(Core :: XUL, defect, P1)

Product:
Core
Component:
XUL
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.8

People

(Reporter: janv, Assigned: bryner)

References

Details

(Keywords: crash, smoketest, topcrash)

Crash Data

Attachments

(3 files, 1 obsolete file)

first patch
27.37 KB, patch
Details | Diff | Splinter Review
testcase
679 bytes, text/html
Details
bulletproofing fix, version 2
4.45 KB, patch
shaver
: superreview+
Details | Diff | Splinter Review 
It crashes because outliner selection methods call content view callbacks
and these callbacks think that their parent element is always <select>.
Severity: normal → blocker
Keywords: crash
Priority: -- → P1
Target Milestone: --- → mozilla0.9.8
Keywords: smoketest
Bryner, your original patch looks pretty good (good work so far).
But I'd like to make nsISelectElement scriptable and move selection callbacks
to select.xml
That should fix this blocker and make it a bit cleaner.
Attached patch first patch — — Splinter Review 
no crash, scriptable select element, removed notification methods
although select.xml needs more loving
Attached file testcase — 

    
    

    
  
anyway, this could go in, since select.xml is not part of default build


    
    

    
  
*** Bug 118363 has been marked as a duplicate of this bug. ***

    
    

    
  
This happens on nightly 2002010508 on Windows 2000.

Talkbacks: TB1276578E, TB1276514Q, and TB1276494E.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        bulletproofing fix (obsolete)
        — 
          — Splinter Review
      

    


  
This fixes the crash, but we should look into a more permanent fix along the
lines of Jan's patch.

    
    

    
  
Comment on attachment 63687 [details] [diff] [review]
bulletproofing fix

r=sdagley

        Attachment #63687 -
        Flags: review+

    
    

    
  
Comment on attachment 63687 [details] [diff] [review]
bulletproofing fix

You really want an inline method for all that repeated stuff.  Really.

    
    

    
  


  
updating per shaver's suggestions

        Attachment #63687 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 63689 [details] [diff] [review]
bulletproofing fix, version 2

Didn't that feel good? sr=shaver, and thanks.

        Attachment #63689 -
        Flags: superreview+

    
    

    
  
Ok, this is fixed.  We'll take the discussion about nsISelectElement elsewhere.

Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
*** Bug 118406 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 118425 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 118433 has been marked as a duplicate of this bug. ***
QA Contact: jrgm → sairuh

    
    

    
  
This was the #1 crash on 1-05, but has no new incidents since the fix. Marking 
VERIFIED, but updating info (KW and summary for talkback tracking).
Status: RESOLVED → VERIFIED
Keywords: topcrash
Summary: Crash while launching preferences → Trunk Crash while launching preferences [@ nsOutlinerContentView::Select]

    
  
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: bugzilla → xptoolkit.widgets
Crash Signature: [@ nsOutlinerContentView::Select]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: