Closed
Bug 1183250
Opened 11 years ago
Closed 10 years ago
Regression: URL location field clear button is misaligned
Categories
(Firefox for iOS :: Theme & Visual Design, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: dhenein, Assigned: bnicholson)
References
Details
Attachments
(2 files, 3 obsolete files)
mockup
See attached mockup with actual/expected.
|
||
Updated•11 years ago
|
Assignee: nobody → bmunar
|
|
||
Comment 1•11 years ago
|
||
Attachment #8633027 -
Flags: review?(dhenein)
|
|
||
Updated•11 years ago
|
Attachment #8633027 -
Flags: review?(dhenein) → review?(bnicholson)
|
|
||
Updated•11 years ago
|
Attachment #8633027 -
Flags: feedback?(dhenein)
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8633027 -
Attachment is obsolete: true
Attachment #8633027 -
Flags: review?(bnicholson)
Attachment #8633027 -
Flags: feedback?(dhenein)
Attachment #8633147 -
Flags: review?(bnicholson)
Attachment #8633147 -
Flags: feedback?(dhenein)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8633147 [details]
Pull request
https://github.com/mozilla/firefox-ios/pull/722/files
|
|
Assignee | |
Comment 4•11 years ago
|
||
Looks like if you link to https://github.com/mozilla/firefox-ios/pull/720/files, Bugzilla doesn't recognize that it's a pull request. Make sure you link to the pull request directly (https://github.com/mozilla/firefox-ios/pull/720/) so that it goes to GitHub when clicking the attachment.
Attachment #8633147 -
Attachment is obsolete: true
Attachment #8633147 -
Flags: review?(bnicholson)
Attachment #8633147 -
Flags: feedback?(dhenein)
Attachment #8633150 -
Flags: review?(bnicholson)
Attachment #8633150 -
Flags: feedback?(dhenein)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Argh, except I used the wrong URL! Let's try this one more time...
Attachment #8633150 -
Attachment is obsolete: true
Attachment #8633150 -
Flags: review?(bnicholson)
Attachment #8633150 -
Flags: feedback?(dhenein)
Attachment #8633152 -
Flags: review?(bnicholson)
Attachment #8633152 -
Flags: feedback?(dhenein)
|
|
||
Comment 6•11 years ago
|
||
omg u cray
|
||
Updated•11 years ago
|
|
|
Assignee | |
Comment 7•11 years ago
|
||
Comment on attachment 8633152 [details] [review]
Pull request
I'm looking into an alternative fix for this.
Attachment #8633152 -
Flags: review?(bnicholson)
Attachment #8633152 -
Flags: feedback?(dhenein)
|
|
||
Updated•11 years ago
|
Assignee: bmunar → bnicholson
|
|
Assignee | |
Comment 8•10 years ago
|
||
Fixed by URL bar refactor (bug 1184239).
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•