Closed
Bug 1183291
Opened 9 years ago
Closed 9 years ago
Factor idl-parser into a Python package
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: new_one, Assigned: new_one)
References
Details
Attachments
(1 file, 3 obsolete files)
5.50 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
We can create a setup.py and move the header, xpidl, typelib code into its own folder. This way we would be able to mirror the directory or put it up on PyPI and include it from elsewhere. Specifically, I'm working on a DXR plugin for xpidl structural analysis and want to borrow the xpidl parser.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → peter.elmers
Assignee | ||
Comment 1•9 years ago
|
||
Move Python code into an xpidl subdirectory, and include a setup.py to allow inclusion from pip install or requirements files. Change build directory variables appropriately.
Assignee | ||
Comment 2•9 years ago
|
||
Move Python code into an xpidl subdirectory, and include a setup.py to allow inclusion from pip install or requirements files. Change build directory variables appropriately.
Attachment #8632972 -
Flags: review?(khuey)
Assignee | ||
Updated•9 years ago
|
Attachment #8632969 -
Attachment is obsolete: true
Comment on attachment 8632972 [details] [diff] [review] factor idl-parser into a Python package Review of attachment 8632972 [details] [diff] [review]: ----------------------------------------------------------------- Please regenerate these patches with file moves instead of deletions and creations. In hg you can do that via 'hg mv --after xpcom/idl-parser/xpidl.py xpcom/idl-parser/xpidl/xpidl.py'
Attachment #8632972 -
Flags: review?(khuey) → review-
Assignee | ||
Comment 4•9 years ago
|
||
Move Python code into an xpidl subdirectory, and include a setup.py to allow inclusion from pip install or requirements files. Change build directory variables appropriately. This patch should record the renames correctly, rather than as removes and adds.
Attachment #8632994 -
Flags: review?(khuey)
Assignee | ||
Comment 5•9 years ago
|
||
Move Python code into an xpidl subdirectory, and include a setup.py to allow inclusion from pip install or requirements files. Change build directory variables appropriately. I had to correct a typo in the setup.py file.
Attachment #8632998 -
Flags: review?(khuey)
Assignee | ||
Updated•9 years ago
|
Attachment #8632994 -
Attachment is obsolete: true
Attachment #8632994 -
Flags: review?(khuey)
Attachment #8632972 -
Attachment is obsolete: true
Attachment #8632998 -
Flags: review?(khuey) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•9 years ago
|
||
Should I push to try server, and which tests would I run there?
Flags: needinfo?(khuey)
Comment 7•9 years ago
|
||
Just a set of builds (no tests needed) should suffice.
Keywords: checkin-needed
Yes, what Ryan said.
Flags: needinfo?(khuey)
Assignee | ||
Comment 9•9 years ago
|
||
Builds complete on try server. https://treeherder.mozilla.org/#/jobs?repo=try&revision=b34cc364e47e
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd182d196f14
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dd182d196f14
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•