Closed Bug 1183291 Opened 5 years ago Closed 5 years ago

Factor idl-parser into a Python package

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: new_one, Assigned: new_one)

References

Details

Attachments

(1 file, 3 obsolete files)

We can create a setup.py and move the header, xpidl, typelib code into its own folder. This way we would be able to mirror the directory or put it up on PyPI and include it from elsewhere.

Specifically, I'm working on a DXR plugin for xpidl structural analysis and want to borrow the xpidl parser.
Assignee: nobody → peter.elmers
Move Python code into an xpidl subdirectory, and include a setup.py to allow
inclusion from pip install or requirements files. Change build directory
variables appropriately.
Move Python code into an xpidl subdirectory, and include a setup.py to allow
inclusion from pip install or requirements files. Change build directory
variables appropriately.
Attachment #8632972 - Flags: review?(khuey)
Attachment #8632969 - Attachment is obsolete: true
Comment on attachment 8632972 [details] [diff] [review]
factor idl-parser into a Python package

Review of attachment 8632972 [details] [diff] [review]:
-----------------------------------------------------------------

Please regenerate these patches with file moves instead of deletions and creations.  In hg you can do that via 'hg mv --after xpcom/idl-parser/xpidl.py xpcom/idl-parser/xpidl/xpidl.py'
Attachment #8632972 - Flags: review?(khuey) → review-
Move Python code into an xpidl subdirectory, and include a setup.py to allow
inclusion from pip install or requirements files. Change build directory
variables appropriately.

This patch should record the renames correctly, rather than as removes and
adds.
Attachment #8632994 - Flags: review?(khuey)
Move Python code into an xpidl subdirectory, and include a setup.py to allow
inclusion from pip install or requirements files. Change build directory
variables appropriately.

I had to correct a typo in the setup.py file.
Attachment #8632998 - Flags: review?(khuey)
Attachment #8632994 - Attachment is obsolete: true
Attachment #8632994 - Flags: review?(khuey)
Keywords: checkin-needed
Should I push to try server, and which tests would I run there?
Flags: needinfo?(khuey)
Just a set of builds (no tests needed) should suffice.
Keywords: checkin-needed
Yes, what Ryan said.
Flags: needinfo?(khuey)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dd182d196f14
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Depends on: 1186896
Depends on: 1200650
You need to log in before you can comment on or make changes to this bug.