1183291 - Factor idl-parser into a Python package

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Peter Elmers [:new_one]]

We can create a setup.py and move the header, xpidl, typelib code into its own folder. This way we would be able to mirror the directory or put it up on PyPI and include it from elsewhere.

Specifically, I'm working on a DXR plugin for xpidl structural analysis and want to borrow the xpidl parser.

Comment 1

[Peter Elmers [:new_one]]

Attachment: factor idl-parser into a Python package

Move Python code into an xpidl subdirectory, and include a setup.py to allow
inclusion from pip install or requirements files. Change build directory
variables appropriately.

Comment 2

[Peter Elmers [:new_one]]

Attachment: factor idl-parser into a Python package

Move Python code into an xpidl subdirectory, and include a setup.py to allow
inclusion from pip install or requirements files. Change build directory
variables appropriately.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8632972 [details] [diff] [review]
factor idl-parser into a Python package

Review of attachment 8632972 [details] [diff] [review]:
-----------------------------------------------------------------

Please regenerate these patches with file moves instead of deletions and creations.  In hg you can do that via 'hg mv --after xpcom/idl-parser/xpidl.py xpcom/idl-parser/xpidl/xpidl.py'

Comment 4

[Peter Elmers [:new_one]]

Attachment: Factor idl-parser into a Python package

Move Python code into an xpidl subdirectory, and include a setup.py to allow
inclusion from pip install or requirements files. Change build directory
variables appropriately.

This patch should record the renames correctly, rather than as removes and
adds.

Comment 5

[Peter Elmers [:new_one]]

Attachment: Factor idl-parser into a Python package

Move Python code into an xpidl subdirectory, and include a setup.py to allow
inclusion from pip install or requirements files. Change build directory
variables appropriately.

I had to correct a typo in the setup.py file.

Comment 6

[Peter Elmers [:new_one]]

Should I push to try server, and which tests would I run there?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Just a set of builds (no tests needed) should suffice.

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yes, what Ryan said.

Comment 9

[Peter Elmers [:new_one]]

Builds complete on try server.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b34cc364e47e

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd182d196f14

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dd182d196f14