Closed
Bug 1183575
Opened 9 years ago
Closed 9 years ago
Configure oauth authentication as a requests authentication backend
Categories
(Tree Management Graveyard :: Treeherder: Client Libraries, defect)
Tree Management Graveyard
Treeherder: Client Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mdoglio, Assigned: mdoglio)
References
Details
Attachments
(1 file)
Now that we use requests to talk to the service api we should segregate the auth logic into a custom requests authentication class. That would make it easier to eventually switch to a different auth mechanism in the future, e.g. a different oauth flow, hawk authentication, etc.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8634177 -
Flags: review?(wlachance)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → mdoglio
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8634177 [details] [review]
PR 763
This looks pretty reasonable. Some nits need to be addressed before this lands, but I'm happy to let this go in if you do that.
Attachment #8634177 -
Flags: review?(wlachance) → review+
|
||
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/b9881f937c0052161f320defadb2d4f3ced89ec1
Bug 1183575 - Create a requests auth backend for 2-legged oauth
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•