Closed
Bug 1183695
Opened 9 years ago
Closed 9 years ago
Save sync logs on disk
Categories
(Firefox for iOS :: Sync, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios | + | --- |
People
(Reporter: rnewman, Assigned: sleroux)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
The short-term part of Bug 1182350.
Reporter | ||
Comment 1•9 years ago
|
||
Steph, wanna steal this? This'll be a little bit of XCGLogger rewiring as we start and end a sync in Profile.swift, flushing to a file in a directory.
Flags: needinfo?(sleroux)
Assignee | ||
Comment 2•9 years ago
|
||
Yup I can take this. Looks like XCGLogger already handles writing logs to disk so we can just add the file logger alongside the console logger and we should be good to go.
Flags: needinfo?(sleroux)
Assignee | ||
Comment 3•9 years ago
|
||
Do we want to write all console log messages to disk or are we only looking for logging performing in Profile.swift?
Flags: needinfo?(rnewman)
Reporter | ||
Comment 4•9 years ago
|
||
Everything in Sync, Storage, FxA, Profile. Probably that means introducing two loggers -- one for browserish things, and one for storageish things.
Flags: needinfo?(rnewman)
Reporter | ||
Comment 5•9 years ago
|
||
An easy first step is to log everything to disk, of course :)
Assignee | ||
Updated•9 years ago
|
Assignee: rnewman → sleroux
Assignee | ||
Comment 6•9 years ago
|
||
I've started with a generic app logger that will log everything to an app.log file for now.
Attachment #8643226 -
Flags: review?(rnewman)
Reporter | ||
Comment 7•9 years ago
|
||
Comment on attachment 8643226 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/862 Two comments on the PR.
Attachment #8643226 -
Flags: review?(rnewman)
Comment 8•9 years ago
|
||
Are we cleaning up the logs at some point?
Reporter | ||
Comment 9•9 years ago
|
||
See comment about log rolling. The current PR doesn't keep logs for longer than the last browser lifespan, so there's nothing to clean up.
Assignee | ||
Updated•9 years ago
|
Attachment #8643226 -
Attachment is obsolete: true
Assignee | ||
Comment 10•9 years ago
|
||
Wrote patch to use rolling logger for sync logs and separate loggers for browser/keychain logging.
Attachment #8644486 -
Flags: review?(rnewman)
Assignee | ||
Comment 11•9 years ago
|
||
Still needs tests and adjustments
Assignee | ||
Comment 12•9 years ago
|
||
I've updated the PR to include the better way of getting folder size and nit fixes: https://github.com/mozilla/firefox-ios/commit/d456246a2b8a4a11ccbf82c4c35b79cf4c7ddef5
Assignee | ||
Comment 13•9 years ago
|
||
I've contacted Nikolai about the licensing and he's fine with licensing it under MPL2.0: https://github.com/NikolaiRuhe/NRFoundation/issues/2 > Hi Stephan! > I hereby grant you the right to use and redistribute my code from NRFileManager using MPL2.0. > Is that OK for your purpose? > Hope I could help :)
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8644486 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/862 I've updated the NSFileManager license and added some tests for the RollingFileLogger class: https://github.com/mozilla/firefox-ios/pull/862/files#diff-a5f77d1d36c08d00638614cfc3f5ed05R9
Reporter | ||
Comment 15•9 years ago
|
||
bafb839
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Attachment #8644486 -
Flags: review?(rnewman)
You need to log in
before you can comment on or make changes to this bug.
Description
•