1183774 - The grouped identity block is overlapping with the separator icon in osx 10.10 when the url bar isn't focused

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Brian Grinstead [:bgrins]]

Attachment: shield.gif

I'm seeing this on the latest fx-team, most likely caused by 1175689.  See the attached screencast.

Open a page like https://www.mozilla.org/en-US/
Notice that the shield is bunched up next to the arrow icon
Focus the URL bar and things get restored

Comment 1

[Brian Grinstead [:bgrins]]

Looks like this was actually triggered by Bug 1180202 overriding the -moz-padding-start on the #identity-box

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: identity-box-padding.patch

Not sure if you think there's a better way than !important here, but the reason this is an issue in Yosemite is that the following rule is overriding the existing 10px value:

  #urlbar:not([focused="true"]):not(:-moz-window-inactive) > #identity-box {
    ...
    padding: 3px 4px;
  }

Comment 3

[:Paolo Amadini]

Comment on attachment 8633676 [details] [diff] [review]
identity-box-padding.patch

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Not sure if you think there's a better way than !important here

Well, there might be, but I don't see it as a reason reason not to land this simple fix in the meantime. I've filed bug 1184060 where we can look into simplifying some of this CSS once we've added the new element enclosing the icons.

Comment 4

[Brian Grinstead [:bgrins]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/c28d52f509c2

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c28d52f509c2

Comment 6

[Catalin Varga [QA][:VarCat]]

Verified as fixed using:

FF 42 Build Id: 20150728030209
OS: Mac Os X 10.10.4