Closed Bug 1183774 Opened 4 years ago Closed 4 years ago

The grouped identity block is overlapping with the separator icon in osx 10.10 when the url bar isn't focused

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 42
Iteration:
42.2 - Jul 27
Tracking Status
firefox42 --- verified

People

(Reporter: bgrins, Assigned: bgrins)

References

()

Details

(Whiteboard: [fxprivacy] [campaign])

Attachments

(2 files)

Attached image shield.gif
I'm seeing this on the latest fx-team, most likely caused by 1175689.  See the attached screencast.

Open a page like https://www.mozilla.org/en-US/
Notice that the shield is bunched up next to the arrow icon
Focus the URL bar and things get restored
Flags: firefox-backlog?
Blocks: 1174986
Rank: 2
Looks like this was actually triggered by Bug 1180202 overriding the -moz-padding-start on the #identity-box
Blocks: 1180202
No longer blocks: 1175689
Points: --- → 2
Flags: qe-verify+
Not sure if you think there's a better way than !important here, but the reason this is an issue in Yosemite is that the following rule is overriding the existing 10px value:

  #urlbar:not([focused="true"]):not(:-moz-window-inactive) > #identity-box {
    ...
    padding: 3px 4px;
  }
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8633676 - Flags: review?(paolo.mozmail)
Iteration: --- → 42.2 - Jul 27
Flags: firefox-backlog? → firefox-backlog+
QA Contact: mwobensmith
Comment on attachment 8633676 [details] [diff] [review]
identity-box-padding.patch

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Not sure if you think there's a better way than !important here

Well, there might be, but I don't see it as a reason reason not to land this simple fix in the meantime. I've filed bug 1184060 where we can look into simplifying some of this CSS once we've added the new element enclosing the icons.
Attachment #8633676 - Flags: review?(paolo.mozmail) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/c28d52f509c2
Whiteboard: [fxprivacy] → [fixed-in-fx-team][fxprivacy]
https://hg.mozilla.org/mozilla-central/rev/c28d52f509c2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][fxprivacy] → [fxprivacy]
Target Milestone: --- → Firefox 42
Whiteboard: [fxprivacy] → [fxprivacy] [campaign]
Verified as fixed using:

FF 42 Build Id: 20150728030209
OS: Mac Os X 10.10.4
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.