Anchor the Control Center to the middle of the icons in the identity block

VERIFIED FIXED in Firefox 42

Status

()

defect
P1
normal
Rank:
2
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

Trunk
Firefox 42
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox42 verified)

Details

(Whiteboard: [fxprivacy] [campaign])

Attachments

(1 attachment)

Assignee

Description

4 years ago
The Control Center panel should anchor to the middle of the visible identity block icons. There are currently one or two icons, but there might be more in the future.

Most probably, a new element enclosing the icons, but not the label, has to be added. This requires CSS changes and can be an occasion to audit and simplify the mechanisms that set the colors and margins in different themes and platforms.
Flags: firefox-backlog+
Assignee

Comment 1

4 years ago
Bug 1185362 made this much simpler, taking for this iteration.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 42.2 - Jul 27
Points: --- → 3
Flags: qe-verify+
Rank: 2
Priority: P2 → P1
QA Contact: mwobensmith
Whiteboard: [fxprivacy] → [fxprivacy] [campaign]
Iteration: 42.2 - Jul 27 → 42.3 - Aug 10
Assignee

Comment 2

4 years ago
Bug 1184060 - Anchor the Control Center to the middle of the icons in the identity block. r=ttaubert
Attachment #8639845 - Flags: review?(ttaubert)
Assignee

Comment 3

4 years ago
Tim, this is probably going to conflict with the panel states refactoring, let me know which one you prefer to land first. I handled bug 1186182 here as well since it was a one line addition and is influenced by this new structure.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=be0686c66d18
Assignee

Comment 4

4 years ago
Location bar structure for reference (the diagram will be updated with the changes):

https://www.lucidchart.com/documents/view/ca6d9936-81ef-4349-b68e-78023efe50a4
Attachment #8639845 - Flags: review?(ttaubert) → review+
Comment on attachment 8639845 [details]
MozReview Request: Bug 1184060 - Anchor the Control Center to the middle of the icons in the identity block. r=ttaubert

https://reviewboard.mozilla.org/r/14247/#review12883

::: browser/themes/shared/identity-block/identity-block.inc.css:114
(Diff revision 1)
> +#urlbar[pageproxystate="invalid"] > #identity-box > #identity-icons > #tracking-protection-icon {
> +  visibility: collapse;
> +}

Great to have that in :) Why don't we use display:none here? That seems to work just as well.
(In reply to :Paolo Amadini from comment #3)
> Tim, this is probably going to conflict with the panel states refactoring,
> let me know which one you prefer to land first. I handled bug 1186182 here
> as well since it was a one line addition and is influenced by this new
> structure.

Go ahead and land your patch, I don't want to block. I'm totally fine with rebasing.
Assignee

Comment 7

4 years ago
https://reviewboard.mozilla.org/r/14247/#review12883

> Great to have that in :) Why don't we use display:none here? That seems to work just as well.

For consistency with other similar rules.
https://hg.mozilla.org/mozilla-central/rev/aada2cbe1929
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified as fixed using the following environment:

FF 42
Build Id: 20150805030208
OS: Win 7 x64, Ubuntu 14.04 x64, Mac OS X 10.10
Status: RESOLVED → VERIFIED

Updated

4 years ago
Depends on: 1231025
You need to log in before you can comment on or make changes to this bug.