1184060 - Anchor the Control Center to the middle of the icons in the identity block

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[:Paolo Amadini]

The Control Center panel should anchor to the middle of the visible identity block icons. There are currently one or two icons, but there might be more in the future.

Most probably, a new element enclosing the icons, but not the label, has to be added. This requires CSS changes and can be an occasion to audit and simplify the mechanisms that set the colors and margins in different themes and platforms.

Comment 1

[:Paolo Amadini]

Bug 1185362 made this much simpler, taking for this iteration.

Comment 2

[:Paolo Amadini]

Attachment: MozReview Request: Bug 1184060 - Anchor the Control Center to the middle of the icons in the identity block. r=ttaubert

Bug 1184060 - Anchor the Control Center to the middle of the icons in the identity block. r=ttaubert

Comment 3

[:Paolo Amadini]

Tim, this is probably going to conflict with the panel states refactoring, let me know which one you prefer to land first. I handled bug 1186182 here as well since it was a one line addition and is influenced by this new structure.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=be0686c66d18

Comment 4

[:Paolo Amadini]

Location bar structure for reference (the diagram will be updated with the changes):

https://www.lucidchart.com/documents/view/ca6d9936-81ef-4349-b68e-78023efe50a4

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8639845 [details]
MozReview Request: Bug 1184060 - Anchor the Control Center to the middle of the icons in the identity block. r=ttaubert

https://reviewboard.mozilla.org/r/14247/#review12883

::: browser/themes/shared/identity-block/identity-block.inc.css:114
(Diff revision 1)
> +#urlbar[pageproxystate="invalid"] > #identity-box > #identity-icons > #tracking-protection-icon {
> +  visibility: collapse;
> +}

Great to have that in :) Why don't we use display:none here? That seems to work just as well.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

(In reply to :Paolo Amadini from comment #3)
> Tim, this is probably going to conflict with the panel states refactoring,
> let me know which one you prefer to land first. I handled bug 1186182 here
> as well since it was a one line addition and is influenced by this new
> structure.

Go ahead and land your patch, I don't want to block. I'm totally fine with rebasing.

Comment 7

[:Paolo Amadini]

https://reviewboard.mozilla.org/r/14247/#review12883

> Great to have that in :) Why don't we use display:none here? That seems to work just as well.

For consistency with other similar rules.

Comment 8

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/aada2cbe1929

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aada2cbe1929

Comment 10

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF 42
Build Id: 20150805030208
OS: Win 7 x64, Ubuntu 14.04 x64, Mac OS X 10.10