1183820 - Expose if XRender is enabled to nsIGfxInfo

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Andrew Comminos [:acomminos]]

In order to fix XRender tests, we should expose whether or not it is enabled to nsIGfxInfo.

Comment 1

[Andrew Comminos [:acomminos]]

Attachment: Add support for checking XRender state to nsIGfxInfo.

Exposes whether XRender is to be used creating offscreen surfaces on GTK.

Comment 2

[Andrew Comminos [:acomminos]]

Attachment: Add XRender state to about:support.

Displays whether XRender is enabled on about:support.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8633674 [details] [diff] [review]
Add support for checking XRender state to nsIGfxInfo.

Review of attachment 8633674 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should just use gfxPlatform::GetAzureBackendInfo to implement this.

Ideally if the moz2d (azure) backend is BACKEND_CAIRO, we'd add an additional property that specifies which backend cairo is using. That's a bit of extra work though, so just having something specific for xrender here seems fine.

Comment 4

[Andrew Comminos [:acomminos]]

Attachment: Expose if cairo uses XRender to GetAzureBackendInfo.

Thanks, this should do the trick.

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8633675 [details] [diff] [review]
Add XRender state to about:support.

Review of attachment 8633675 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/Troubleshoot.jsm
@@ +359,5 @@
>        D2DEnabled: "direct2DEnabled",
>        DWriteEnabled: "directWriteEnabled",
>        DWriteVersion: "directWriteVersion",
>        cleartypeParameters: "clearTypeParameters",
> +      XRenderEnabled: "xrenderEnabled",

Assuming this is implemented so it doesn't show up on platforms where it's not relevant, rs=me.

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8633675 [details] [diff] [review]
Add XRender state to about:support.

Sorry about the mid-air collision.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/766bade5c8b5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/766bade5c8b5