Expose if XRender is enabled to nsIGfxInfo

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: acomminos, Assigned: acomminos)

Tracking

unspecified
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

In order to fix XRender tests, we should expose whether or not it is enabled to nsIGfxInfo.
Exposes whether XRender is to be used creating offscreen surfaces on GTK.
Attachment #8633674 - Flags: review?(matt.woodrow)
Displays whether XRender is enabled on about:support.
Attachment #8633675 - Flags: review?(MattN+bmo)
Comment on attachment 8633674 [details] [diff] [review]
Add support for checking XRender state to nsIGfxInfo.

Review of attachment 8633674 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should just use gfxPlatform::GetAzureBackendInfo to implement this.

Ideally if the moz2d (azure) backend is BACKEND_CAIRO, we'd add an additional property that specifies which backend cairo is using. That's a bit of extra work though, so just having something specific for xrender here seems fine.
Attachment #8633674 - Flags: review?(matt.woodrow) → review-
Thanks, this should do the trick.
Attachment #8633674 - Attachment is obsolete: true
Attachment #8633675 - Attachment is obsolete: true
Attachment #8633675 - Flags: review?(MattN+bmo)
Attachment #8633684 - Flags: review?(matt.woodrow)
Comment on attachment 8633675 [details] [diff] [review]
Add XRender state to about:support.

Review of attachment 8633675 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/Troubleshoot.jsm
@@ +359,5 @@
>        D2DEnabled: "direct2DEnabled",
>        DWriteEnabled: "directWriteEnabled",
>        DWriteVersion: "directWriteVersion",
>        cleartypeParameters: "clearTypeParameters",
> +      XRenderEnabled: "xrenderEnabled",

Assuming this is implemented so it doesn't show up on platforms where it's not relevant, rs=me.
Attachment #8633675 - Attachment is obsolete: false
Comment on attachment 8633675 [details] [diff] [review]
Add XRender state to about:support.

Sorry about the mid-air collision.
Attachment #8633675 - Attachment is obsolete: true
Attachment #8633684 - Flags: review?(matt.woodrow) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/766bade5c8b5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.