Closed Bug 1183825 Opened 7 years ago Closed 7 years ago

PushMessageData methods should be unavailable until we support data.

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: nsm, Assigned: nsm)

References

Details

Attachments

(1 file)

Summary: PushMessageData methods should fail since we don't support data yet. → PushMessageData methods should be unavailable until we support data.
Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt
Attachment #8633686 - Flags: review?(martin.thomson)
Comment on attachment 8633686 [details]
MozReview Request: Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

https://reviewboard.mozilla.org/r/13243/#review11883

::: dom/workers/ServiceWorkerEvents.h
(Diff revision 1)
> -  void Json(JSContext* cx, JS::MutableHandle<JSObject*> aRetval);
> -  void Text(nsAString& aData);
> -  void ArrayBuffer(JSContext* cx, JS::MutableHandle<JSObject*> aRetval);
> -  mozilla::dom::Blob* Blob();

Is it really necessary to remove these?  I would have thought that removing the WebIDL would be sufficient.
Attachment #8633686 - Flags: review?(martin.thomson)
It is sufficient to just update webidl, but I don't like leaving code behind that doesn't do anything. I leave webidl commented since that helps when comparing specs to what Gecko does.
I only suggested that you leave it so that you don't rot the patch that actually fixes this, which (I hope) will land soon.
Comment on attachment 8633686 [details]
MozReview Request: Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt
Attachment #8633686 - Flags: review?(martin.thomson) → review+
Comment on attachment 8633686 [details]
MozReview Request: Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

https://reviewboard.mozilla.org/r/13243/#review11889

Ship It!
Comment on attachment 8633686 [details]
MozReview Request: Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

It is mystery to me why we have PushEvent then at all, or at least PushMessageData. 
I would rather hide .data from PushEvent and disable the whole 
PushMessageData interface. With that, r+
Attachment #8633686 - Flags: review?(bugs) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2d2c3e879545268d628505c693cf4dcf9615bacb
changeset:  2d2c3e879545268d628505c693cf4dcf9615bacb
user:       Nikhil Marathe <nsm.nikhil@gmail.com>
date:       Tue Jul 14 13:45:01 2015 -0700
description:
Bug 1183825 - Hide PushMessageData methods until we support sending push data. r=mt,smaug
https://hg.mozilla.org/mozilla-central/rev/2d2c3e879545
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.