1183825 - PushMessageData methods should be unavailable until we support data.

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8633686 [details]
MozReview Request: Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

https://reviewboard.mozilla.org/r/13243/#review11883

::: dom/workers/ServiceWorkerEvents.h
(Diff revision 1)
> -  void Json(JSContext* cx, JS::MutableHandle<JSObject*> aRetval);
> -  void Text(nsAString& aData);
> -  void ArrayBuffer(JSContext* cx, JS::MutableHandle<JSObject*> aRetval);
> -  mozilla::dom::Blob* Blob();

Is it really necessary to remove these?  I would have thought that removing the WebIDL would be sufficient.

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

It is sufficient to just update webidl, but I don't like leaving code behind that doesn't do anything. I leave webidl commented since that helps when comparing specs to what Gecko does.

Comment 4

[Martin Thomson [:mt:]]

I only suggested that you leave it so that you don't rot the patch that actually fixes this, which (I hope) will land soon.

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Ok I'll leave it in :)

Comment 6

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8633686 [details]
MozReview Request: Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

Comment 7

[Martin Thomson [:mt:]]

Comment on attachment 8633686 [details]
MozReview Request: Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

https://reviewboard.mozilla.org/r/13243/#review11889

Ship It!

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8633686 [details]
MozReview Request: Bug 1183825 - Hide PushMessageData methods until we support sending push data. r?mt

It is mystery to me why we have PushEvent then at all, or at least PushMessageData. 
I would rather hide .data from PushEvent and disable the whole 
PushMessageData interface. With that, r+

Comment 9

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2d2c3e879545268d628505c693cf4dcf9615bacb
changeset:  2d2c3e879545268d628505c693cf4dcf9615bacb
user:       Nikhil Marathe <[e-mail]>
date:       Tue Jul 14 13:45:01 2015 -0700
description:
Bug 1183825 - Hide PushMessageData methods until we support sending push data. r=mt,smaug

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2d2c3e879545