1183873 - 5,000 instances of "'!mContentCache.CacheEditorRect(this, &aIMENotification)'" and associated warnings emitted from widget/PuppetWidget.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Eric Rahm [:erahm]]

> 2491 [NNNNN] WARNING: '!mContentCache.CacheEditorRect(this, &aIMENotification)', file widget/PuppetWidget.cpp, line 829

This warning [1], introduced in bug 1166436 patch 12 shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:1013
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:804
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm53-tests1-linux64-build0.txt:483
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:108
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm117-tests1-linux64-build8.txt:31
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build0.txt:14
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:11
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-3-bm122-tests1-linux64-build17.txt:10
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:7
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:3
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:2
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm123-tests1-linux64-build2.txt:1
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm68-tests1-linux64-build0.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm122-tests1-linux64-build12.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm51-tests1-linux64-build0.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:1

It shows up in 820 tests. A few of the most prevalent:

> 46 - browser/base/content/test/general/browser_domFullscreen_fullscreenMode.js
> 41 - browser/components/sessionstore/test/browser_formdata_cc.js
> 37 - dom/manifest/test/browser_ManifestObtainer_obtain.js
> 37 - browser/base/content/test/general/browser_pageInfo.js
> 36 - browser/components/sessionstore/test/browser_615394-SSWindowState_events.js
> 30 - browser/components/sessionstore/test/browser_522545.js
> 29 - browser/base/content/test/general/browser_bug553455.js
> 24 - browser/components/sessionstore/test/browser_595601-restore_hidden.js
> 19 - toolkit/modules/tests/browser/browser_RemotePageManager.js
> 19 - browser/components/sessionstore/test/browser_formdata_format.js

[1] https://hg.mozilla.org/mozilla-central/annotate/e786406bc683/widget/PuppetWidget.cpp#l829

Comment 2

[Eric Rahm [:erahm]]

This is related to:
> 2491 [NNNNN] WARNING: '!editorRectEvent.mSucceeded', file widget/ContentCache.cpp, line 256

Comment 3

[Eric Rahm [:erahm]]

Attachment: Just log if WidgetQueryContentEvent fails

Masayuki, are you okay with just using the MOZ_LOG here?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8636890 [details] [diff] [review]
Just log if WidgetQueryContentEvent fails

No, this is what we need to fix completely before releasing e10s.

Comment 5

[Eric Rahm [:erahm]]

Is there an overall bug for fixing this that we can block against?

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

No. We need to investigate why the query failed.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I landed a patch for bug 1191213 into m-i. That must fix (almost?) all of this bug. Please check it later.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The cset is https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5f3758c4704f

However, it doesn't kick to build on desktop platforms. You can check it with next cset:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=752bf6f11fbf

Comment 9

[Eric Rahm [:erahm]]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #8)
> The cset is
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> inbound&revision=5f3758c4704f
> 
> However, it doesn't kick to build on desktop platforms. You can check it
> with next cset:
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> inbound&revision=752bf6f11fbf

Thank you Masayuki. Once it hits m-c I'll check the logs and verify.

Comment 10

[Eric Rahm [:erahm]]

(lets keep the ni so I don't forget)

Comment 11

[Eric Rahm [:erahm]]

Looks good, I think we can resolve this now that bug 1191213 has been closed.