118388 - Whenever I read specific mail the sender is added to the Collected Addresses again

Status: VERIFIED DUPLICATE of bug 129393

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Henrik Gemal]

I have a mail that whenever I select it, the sender of the mail is readded to 
the Collected Addresses so that the sender now appears 10 times in the 
Collected Addresses display.

Since I dont want to attach the mail here, I'd be happy to send it directly.

build 20020104

Comment 1

[Henrik Gemal]

It seems to happen it you have an imcomplete mail. There's a bug in Microsoft 
Exchange server that causes Mozilla not getting the entire mail. This again is 
causing the constant adding of the sender to the Collected Addresses.

Comment 2

[Nathan Bidwell]

I can also verify that this has happened to me, including messages that have not
travelled through an exchange server.  (I haven't tracked down any specific
messages that cause this, but can if need be.)  Note that the address book
entries are all exact duplicates.

Sun sparc/solaris build 2002013122
(old build as nightlies are having build problems on Solaris....)

Comment 3

[Scott Davis]

I see this also (Solaris 0.9.9 build 2002031103). I use a Solaris-based IMAP
server, but all the email has passed through Exchange to get to me. I think it
was also happening with older releases.

One observation: ALL duplicate entries are from users who have upper case
letters somewhere in their email address. I have no duplicates of entries with
an entirely lower-case address, although not all addresses with uppercase seem
to have been duplicated.

Comment 4

[Mike Bremford]

I also get this, using build 0.9.9 on Windows and Linux, talking to an IMAP
server (UW IMAP 2000c on Linux).

I can also confirm that the common thread, if you pardon the pun, could well be
the use of uppercase characters in the actual address - uppercase in the
printable name seems to be OK. e.g. "Jim Jones <[e-mail]>" gives
duplicates, "Jim Jones <[e-mail]>" is fine.

MS Exchange is not the culprit - I suspect it's to do with IMAP servers in general.

Comment 5

[Ian Neal]

I'm using buildid 2002032810 on Win XP to a Netscape 4.15 messenger server
running on Solaris 2.6. I did used to get the problem but now seems to have gone
away. This includes e-mail addresses of people with uppercase letters in their
userid.

So WFM

Comment 6

[Stan Underwood]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9) Gecko/20020311

Same issue with mixed case being duplicated, all lc addy's no problem.

Comment 7

[Boris 'pi' Piwinger]

Comments show it happens on various OS and platform (setting ALL). Also to me:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9+) Gecko/20020408
I also don't see dupes for all lowercase entries.

pi

Comment 8

[Ian Neal]

I've managed to get a mixed case duplicate as well:-

Support <[e-mail]> 

and 

support <[e-mail]>

Comment 9

[Frank Schönheit]

happens to me, too, win2000/nt/xp, 0.9.9
last checked (with some 0.9.8 I think) explicitly on a machine even without any
(remote or local) news/mail server: Just selecting the mails in an MBX file I
copied from elsewhere into my Local Folders gave me the duplicates.

Comment 10

[Frank Schönheit]

Attachment: testcase for reproducing the bug

the file attached allows to reproduce the problem. Simply copy it into the
"Local Folders" of your Mail folder. Select the first message, select the
second message -> you got a duplicate address in your "Collected Addresses"
(BugDoc@localhost).

Comment 11

[Frank Schönheit]

debugged a little bit into it, and as far as I understand it, it's really that
the character case causes the trouble.

In short:
To determine if a new card needs to be added, the primary email is looked up
lower-case, means "[e-mail]" is searched as
"[e-mail]". Unfortunately, the real search is still done
case-sensitive, so the card is not found.

In long:
The address collector implementation (nsAbAddressCollecter) does a
GetCardFromAttribute on the address book, with a parameter requesting case
insensitive search. This is passed to GetRowFromAttribute, where, when
case-insensitivity is requested, the input string is converted to lower case.
After this, the case-flag is _not_used_anymore_.
The GetRowForCharColumn calls the FindRow on it's nsIMdbStore, and some levels
down the stack, morkBookAtom::HashFormAndBody hashs the input address -
case-sensitively.
To me it seems (admittedly I know the address book code for some hours only :)
that the "caseInsensitive" flag on nsIAddrDatabase::getCardFromAttribute is
useless: The underlying store does not know anything about case sensivitiy (it's
way too abstract for this, it just operates on columns which, by accident, in
the case of an address book contain UTF-strings). And from what I've seen, I
think this info can't (and shouldn't) be passed down to the store.

So the alternative (iow: a short fix) would be to store _all_ collected
addresses with a lower-case primary email, _or_ to look up addresses case-sensitive.
The former would have the disadvantage of simply looking ugly :), the latter
would mean that both "[e-mail]" and "[e-mail]" would
be added as separate entries - which is not as worse as the current situation ....

Comment 12

[Frank Schönheit]

Can anybody confirm that this is a duplicate of bug 121478 (which is fixed 
since RC1)?

Comment 13

[Boris 'pi' Piwinger]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0+) Gecko/20020503

I just tried to reproduce with two e-mails where only the capitalization of the
addess differed. I got to entries in collected addresses. So at least part of
the problem is still there.

pi

Comment 14

[Frank Schönheit]

pi,
this second part is bug 129393 (referred from bug 128535, referred from bug
121478) I think. So in my opinion, both parts are duplicates:
a. repeatedly adding a mail with capital letters to the collected addresses:
duplicate of bug 121478
b. adding every case-permutation of an address to the collected addresses:
duplicate of bug 129393

Comment 15

[Boris 'pi' Piwinger]

I agree. I did some more testing and found that what is left is bug 129393.
Duping on it.

pi

*** This bug has been marked as a duplicate of 129393 ***

Comment 16

[Ninoschka Baca]

Verified duplicate.

Comment 17

[Merlin Cul Kirkpatrick]

To the best of my knowledge this bug still exists in the main code.  To get it fixed please go to bug 129393 https://bugzilla.mozilla.org/show_bug.cgi?id=129393 and click the vote button to raise its level of importance.