1183962 - selecting "WebIDE" from the hamburger menu adds it to the toolbar

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect, P3)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: issue.gif

When selecting "WebIDE" from the "hamburger menu -> developer", the "WebIDE" icon will be added to the toolbar next to the Hello icon.

* added a short .gif to illustrate the issue

STR:

- install the latest m-c
- once installed, select "hamburger menu -> developer -> WebIDE"
- you'll notice the WebIDE icon will appear in the toolbox next to the Hello icon

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Indeed, that was done on purpose about a year ago to promote WebIDE. I take it that you want to suggest that we reconsider that choice?

Comment 2

[Kamil Jozwiak [:kjozwiak]]

I personally think we shouldn't be adding icons into people's toolbar automatically, that should be the users choice rather than ours. It's fine if we were promoting the feature but seems a bit strange to me that using it will automatically just place a new icon and the other developer tools don't.

I like to keep my toolbar pretty clean with just a few icons and was pretty surprised that the WebIDE icon suddenly appeared in my toolbar. If it's been like this for over a year and no one has really complained about it, I guess there's no point in spending time on changing it :)

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It's definitely strange.  At this point, I'll believe we'll "fix" this be removing WebIDE.

Comment 4

[Julian Descottes [:jdescottes]]

WebIDE triage. Filter on TRIAGE-JD201705

I would actually like to remove some of devtools entry points before moving devtools as an addon (see Bug 1356226)
The webIDE button is one of them. Removing this behavior would simplify the decision.

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1183962 - stop installing webide button in menu or navbar automatically;

Review commit: https://reviewboard.mozilla.org/r/135626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135626/

Comment 6

[Julian Descottes [:jdescottes]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e35cf55e8fa413bac24b2c6d53eb3956e21d8301

I followed what jryans proposed in Bug 1361146 comment 1. The webide button is no longer automatically added anywhere, whether it's a normal build or a dev edition build. The button is still accessible via the customizable ui interface in case users want to add it to their UI. For users who already had it in their UI, the button will remain at the same spot. This only affects new profiles.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8863907 [details]
Bug 1183962 - stop installing webide button in menu or navbar automatically;

https://reviewboard.mozilla.org/r/135626/#review138656

Thanks for working on this! :)

Should you remove the target[1] from UITour.jsm as well?  It seems like it won't match now, and we probably don't want any tours for it anyway...

[1]: http://searchfox.org/mozilla-central/rev/abe68d5dad139e376d5521ca1d4b7892e1e7f1ba/browser/components/uitour/UITour.jsm#211

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8863907 [details]
Bug 1183962 - stop installing webide button in menu or navbar automatically;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135626/diff/1-2/

Comment 9

[Julian Descottes [:jdescottes]]

Thanks for the review! I agree it makes sense to remove it from the UITour code. Also removed a few remaining references to the devtools webide widget prefs.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a65c362959a463abe9f335573bea8d6de94144e

Comment 10

[Julian Descottes [:jdescottes]]

Comment on attachment 8863907 [details]
Bug 1183962 - stop installing webide button in menu or navbar automatically;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135626/diff/2-3/

Comment 11

[Julian Descottes [:jdescottes]]

Comments from webide-prefs.js needed to be switched to JS comments since the file is no longer preprocessed.

New and hopefully last try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed0e716c5f3374cbcd91563f7e311ed49fa20430

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03cfa568b940
stop installing webide button in menu or navbar automatically;r=jryans

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/03cfa568b940

Comment 14

[Saheda Reza [:Antora]]

I have reproduced this bug according to (2015-07-14)

Fixing bug is verified on latest Nightly-- Build ID :(20170614030206), 
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:56.0) Gecko/20100101 Firefox/56.0

Tested OS-- Windows7 32bit

Comment 15

[Mihai Boldan, Desktop QA [:mboldan]]

Thanks Saheda Reza for helping us. 
I've also verified the issue on Latest Nightly (56.0a1 (2017-06-20)and on Firefox 55.0b3 (64-bit), under Mac OS X 10.12.5 and under Ubuntu 16.04x64 and I confirm that the issue is no longer reproducible.
Based on my testing and on Comment 14, I'm marking this issue Verified Fixed.