1184008 - Only a manual review is available

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Alervd]

Attachment: extension.xpi

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150630154324

Steps to reproduce:

I have extension without any binary components.
Addon validation does not issue any signing warnings.
But addon is not signed automatically. 



Actual results:

I have to wait for a manual review.


Expected results:

My addon should be signed immediately. 
Am I wrong?

Comment 1

[Mathieu Agopian [:magopian]]

Hello,

automatic validation and signing is only available for unlisted add-ons. To submit an unlisted add-on, you need to check the "Do not list my add-on on this site (beta)" checkbox on the second step of the add-on submission flow (just before uploading the file): https://addons.mozilla.org/en-us/developers/addon/submit/2

I'm closing this ticket as invalid, but if you did indeed select this checkbox, please attach the file you're trying to submit to this bug so I can try to reproduce your issue, thanks!

Comment 2

[Alervd]

Addon is unlisted.

Comment 3

[Alervd]

https://addons.mozilla.org/en-US/developers/addon/free-download-manager-plugin/versions

Comment 4

[Alervd]

File is attached.

Comment 5

[Mathieu Agopian [:magopian]]

Did you switch your add-on to unlisted after submitting this new version?

Comment 6

[Alervd]

No.

Comment 7

[Mathieu Agopian [:magopian]]

Attachment: Screen Shot 2015-07-15 at 11.50.45.png

After investigation, I understand what's happening: your add-on status is "fully reviewed". When switching to unlisted, it didn't change this status.

When submitting an version to an unlisted add-on, it uses the current status to decide whether it can automatically sign it or not. Automatic signing isn't enabled for fully reviewed add-ons, because a fully reviewed add-on can be side-loaded, and thus needs a manual review (it's the same if you create a new unlisted add-on, and select the "This add-on will be side-loaded via application installers." checkbox).

:kmag, :jorgev, do you have any thoughts about that? Should we automatically change an add-on status to "preliminary reviewed" when switching it to unlisted? Or should we disable switching to unlisted for fully reviewed add-ons? Or simply display a note on the "switch to unlisted popup" (see attached screenshot) warning about that?

I'd be in favor of the last proposition, to avoid further edge cases and confusion for the developers.

Comment 8

[Alervd]

It seems I understood the reason too. Our addon is "side-loaded", i.e. it is distributed as a component of Free Download Manager. It's installed by Free Download Manager to Firefox.
Such addons can't be signed automatically. Am I right?
But, why can't? Manual sign is extremely slow (last time we signed extension it took about 2 months(!!!) ) and will prevent us from delivering extension updates to our users in acceptable amount of time.

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

I think we should default to preliminary review for all add-ons that move to unlisted. I haven't looked at the UI, but it would also be good to have the checkbox to request sideloading somewhere in it.

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

Additionally, it doesn't look like we're communicating very well what's going on. It'd be good to explain why an add-on requires manual review, either because of validation or because they requested sideloading.

Comment 13

[Wil Clouser [:clouserw]]

Can you be specific about what needs to happen in this bug?  Thanks.

Comment 14

[Jorge Villalobos [:jorgev] (he/him)]

As I gathered from our latest discussion, when an add-on is switched from listed to unlisted (or vice versa), we will kick off the submission process from the start. That should resolve the issues here, which are (1) choosing the right level (full or prelim), and (2) informing the developer of the choices available. This could probably be duped to the bug that are filed for the new plan (if there are any).

Comment 15

[Mathieu Agopian [:magopian]]

Closing this as it was decided we won't be implementing the switch from unlisted to listed, and will remove the switch from listed to unlisted.

See bug 1200777, bug 1200779 and bug 1200785