Closed Bug 1184055 Opened 9 years ago Closed 9 years ago

[B2G] Mute audio by default in b2g

Categories

(Firefox OS Graveyard :: AudioChannel, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-master fixed)

RESOLVED FIXED
FxOS-S3 (24Jul)
Tracking Status
b2g-master --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

Details

(Whiteboard: [backout-asap])

Attachments

(1 file, 1 obsolete file)

Bug1113086 forgot to merge this changeset into m-c. We need to mute audio by default, and wait to be opened by the system app.
Attached patch Muted by default in b2g (obsolete) — Splinter Review
Hi, Baku, Could you help me review this patch? We forgot to add it into the m-c. Thanks!
Attachment #8634013 - Flags: review?(amarchesini)
Comment on attachment 8634013 [details] [diff] [review] Muted by default in b2g Review of attachment 8634013 [details] [diff] [review]: ----------------------------------------------------------------- Test this patch a lot before landing it! Thanks!
Attachment #8634013 - Flags: review?(amarchesini) → review+
Adding the preference in prefs_general.js to avoid the crash on mochitest. Because the mochitest doesn't have the audio competing logic, the audio can't be muted by default. Try-server result. https://treeherder.mozilla.org/#/jobs?repo=try&revision=df0e68064485
Attachment #8634013 - Attachment is obsolete: true
Keywords: checkin-needed
This might be causing a smoke test blocker. We may need this backed out.
QA Whiteboard: [QAnalyst-Triage+]
Whiteboard: [backout-asap]
Hi, KTucker, We have already two bugs to handle these issues, bug1185051 and bug1181982. These bug will be landed soon.
Hi, Ryan, Could we change the status of this issue to "RESOLVED"? The regression bugs are all fixed now. Thanks :)
Flags: needinfo?(ryanvm)
Fine by me, not sure why this didn't get marked when the patch got merged to m-c. https://hg.mozilla.org/mozilla-central/rev/3745c3df8072
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S3 (24Jul)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: