Closed
Bug 1184055
Opened 9 years ago
Closed 9 years ago
[B2G] Mute audio by default in b2g
Categories
(Firefox OS Graveyard :: AudioChannel, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S3 (24Jul)
Tracking | Status | |
---|---|---|
b2g-master | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
(Whiteboard: [backout-asap])
Attachments
(1 file, 1 obsolete file)
2.12 KB,
patch
|
Details | Diff | Splinter Review |
Bug1113086 forgot to merge this changeset into m-c.
We need to mute audio by default, and wait to be opened by the system app.
Assignee | ||
Comment 1•9 years ago
|
||
Hi, Baku,
Could you help me review this patch?
We forgot to add it into the m-c.
Thanks!
Attachment #8634013 -
Flags: review?(amarchesini)
Comment 2•9 years ago
|
||
Comment on attachment 8634013 [details] [diff] [review]
Muted by default in b2g
Review of attachment 8634013 [details] [diff] [review]:
-----------------------------------------------------------------
Test this patch a lot before landing it! Thanks!
Attachment #8634013 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Adding the preference in prefs_general.js to avoid the crash on mochitest. Because the mochitest doesn't have the audio competing logic, the audio can't be muted by default.
Try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=df0e68064485
Attachment #8634013 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 5•9 years ago
|
||
This might be causing a smoke test blocker. We may need this backed out.
QA Whiteboard: [QAnalyst-Triage+]
Whiteboard: [backout-asap]
Assignee | ||
Comment 6•9 years ago
|
||
Hi, KTucker,
We have already two bugs to handle these issues, bug1185051 and bug1181982.
These bug will be landed soon.
Assignee | ||
Comment 7•9 years ago
|
||
Hi, Ryan,
Could we change the status of this issue to "RESOLVED"?
The regression bugs are all fixed now.
Thanks :)
Flags: needinfo?(ryanvm)
Comment 8•9 years ago
|
||
Fine by me, not sure why this didn't get marked when the patch got merged to m-c.
https://hg.mozilla.org/mozilla-central/rev/3745c3df8072
Status: NEW → RESOLVED
Closed: 9 years ago
status-b2g-master:
--- → fixed
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S3 (24Jul)
You need to log in
before you can comment on or make changes to this bug.
Description
•