1184131 - Slide show not rendered on about:addons > Get Add-ons

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect)

Description

[Alice0775 White]

Steps to reproduce:
1. Open aboud:addons and select Get Add-ons pane

Actual results:
Slide show not display

And an error is shown in Web Console:
SyntaxError: JSON.parse: expected property name or '}' at line 1 column 2 of the JSON data discovery-min.js:5:16124

Expected Results:
Slide show should display

Comment 1

[Alice0775 White]

Attachment: screenshot comparison between Firefox40.0b4 and Aurora41.0a2

Comment 2

[Alice0775 White]

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5e97f3b44653&tochange=9a04997eec28

Triggered by: Bug 1093611

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Problem seems to be that in extensions.js we do setURL(url + "#" + JSON.stringify(list));
After bug 1093611 url.hash no longer automatically unescapes the result, so we have to call unescape(url.hash) to get the same value.

Comment 5

[Mathieu Agopian [:magopian]]

Excellent investigation! It seems the extensions.js file comes from https://github.com/mozilla/nunjucks/blob/master/tests/express-sample/js/extensions.js, which is (I think) a dependency of commonplace.

I guess we need to update the requirements to use a more recent version, and hope this has been fixed (or submit a bug on nunjucks?).

Do you want to do that? I can help if you want to create a PR for that on AMO ;)

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

This bug is going to hit beta in less than two weeks, so we should fix it for next week's push.

Comment 7

[Mathieu Agopian [:magopian]]

It seems the problem wasn't coming from nunjucks but from discovery_pane.js on olympia.

PR: https://github.com/mozilla/olympia/pull/630

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/b5b301bfba1260c1860e992cae5ef5e677ba3554
location.hash isn't unescaped automatically anymore in FF >= 41 (bug 1184131)

https://github.com/mozilla/olympia/commit/7581411223af1e14b85771db50e70a11bbb7539a
Merge pull request #630 from magopian/1184131-unescape-location.hash

location.hash isn't unescaped automatically anymore in FF >= 41 (bug 1184131)