Closed
Bug 1184486
Opened 9 years ago
Closed 9 years ago
Let PerformanceStats.jsm play nicer with process-per-tab
Categories
(Toolkit :: Performance Monitoring, defect)
Toolkit
Performance Monitoring
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Assignee | ||
Updated•9 years ago
|
Summary: Let PerformanceStats.jsm play nicer with tab-per-process → Let PerformanceStats.jsm play nicer with process-per-tab
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r?mconley
Attachment #8634665 -
Flags: review?(mconley)
Comment 2•9 years ago
|
||
Comment on attachment 8634665 [details] MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley https://reviewboard.mozilla.org/r/13429/#review12085 One suggestion, one question. ::: toolkit/components/perfmonitoring/tests/browser/browser_compartments.js:37 (Diff revision 1) > +let pid = getpid(); Because of the mixture of scopes in this file, pid is getting overloaded and it gets a bit confusing. Maybe: `const PARENT_PID = getpid();`? ::: toolkit/components/perfmonitoring/tests/browser/browser_compartments.js:50 (Diff revision 1) > + let sysName = Services.sysinfo.getPropertyAsAString("name"); > + if (sysName == "Windows_NT") { > + let libc = ctypes.open("kernel32.dll"); > + return libc.declare("GetCurrentProcessId", > + ctypes.winapi_abi, > + ctypes.uint32_t > + ); > + } else { > + let libc = ctypes.open(ctypes.libraryName("c")); > + return libc.declare("getpid", > + ctypes.default_abi, > + ctypes.int // PID > + ); > + } Will this work with sandboxing?
Attachment #8634665 -
Flags: review?(mconley)
Assignee | ||
Comment 3•9 years ago
|
||
https://reviewboard.mozilla.org/r/13429/#review12085 > Will this work with sandboxing? Well, if `getpid`/`GetCurrentProcessId` is blocked by sandboxing, the C++ code will also break, so I'm going to assume that this should work.
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8634665 [details] MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r?mconley
Attachment #8634665 -
Flags: review?(mconley)
Comment 5•9 years ago
|
||
Can we run this through Try now so it can land ASAP once it has review? It's blocking a frequent crash in automation :(
Blocks: 1183236
Assignee | ||
Comment 6•9 years ago
|
||
For consistency, I have moved the fixup patch to bug 1175098.
Comment 7•9 years ago
|
||
Comment on attachment 8634665 [details] MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley https://reviewboard.mozilla.org/r/13429/#review12411 Ship It!
Attachment #8634665 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8634665 [details] MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley
Attachment #8634665 -
Attachment description: MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r?mconley → MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley
Attachment #8634665 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=07937c30c948
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dteller
Assignee | ||
Comment 10•9 years ago
|
||
Mmmh... Apparently, my libc call in the test doesn't work on Linux. I'll see what I can do about that.
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8634665 [details] MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley
Assignee | ||
Comment 12•9 years ago
|
||
Bug 1184486 - Publish pid in nsIAppStartup;r?bsmedberg
Attachment #8638432 -
Flags: review?(benjamin)
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8638432 [details] MozReview Request: Bug 1184486 - Publish pid in nsIAppStartup;r?bsmedberg Bug 1184486 - Publish pid in nsIAppStartup;r?bsmedberg
Attachment #8638432 -
Flags: review?(benjamin)
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8634665 [details] MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley
Attachment #8634665 -
Flags: review?(mconley)
Assignee | ||
Updated•9 years ago
|
Attachment #8638432 -
Attachment is obsolete: true
Assignee | ||
Comment 15•9 years ago
|
||
Comment on attachment 8634665 [details] MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley
Assignee | ||
Updated•9 years ago
|
Attachment #8634665 -
Flags: review?(mconley)
Assignee | ||
Comment 16•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae22babdf347
Keywords: checkin-needed
Comment 17•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/82fac7af188e
Keywords: checkin-needed
Comment 18•9 years ago
|
||
Backed out for Static Analysis failures. https://treeherder.mozilla.org/logviewer.html#?job_id=3974414&repo=fx-team https://hg.mozilla.org/integration/fx-team/rev/9f06d4c4da0f
Assignee | ||
Updated•9 years ago
|
Attachment #8634665 -
Flags: review?(mconley)
Assignee | ||
Comment 19•9 years ago
|
||
Comment on attachment 8634665 [details] MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley
Comment 20•9 years ago
|
||
Comment on attachment 8634665 [details] MozReview Request: Bug 1184486 - Let PerformanceStats.jsm play nicer with process-per-tab;r=mconley https://reviewboard.mozilla.org/r/13429/#review12961 Ship It!
Attachment #8634665 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 21•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4892f93c5e8e Thanks for the help with mozreview, mconley.
Keywords: checkin-needed
Comment 22•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/14ae070d4a41
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/14ae070d4a41
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•