1184554 - Hide View Later extension when in Firefox

Status: NEW

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Visit a site, tap "View Later" in Firefox. Nothing happens.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Lets disable it when in Firefox. Like we do with the Safari Reading List. I think we can simply exclude it by including its identifier in the exception list?

Comment 2

[Richard Newman [:rnewman]]

Well, this is strange.

                // Hide 'Add to Reading List' which currently uses Safari.
                // Also hide our own View Later… after all, you're in the browser!
                activityViewController.excludedActivityTypes = [
                    UIActivityTypeAddToReadingList,
                    "org.mozilla.ios.Fennec.ViewLater",
                ]

browserToolbarDidPressShare(_:button:): Selected activity type: org.mozilla.ios.Fennec.ViewLater

Comment 3

[Richard Newman [:rnewman]]

---
As of iOS 8.1 UIActivityViewController ignores third-party values in excludedActivityTypes. The system options like UIActivityTypePostToFacebook and UIActivityTypePostToTwitter are okay, but anything that doesn't start with com.apple.UIKit.activity is ignored. I opened Radar #19430419 for this issue, and if you would also like this functionality please open a duplicate of it.
---

http://johnszumski.com/blog/excluding-third-party-apps-from-ios-8-share-sheet

Trying with 8.3, see if it's any better.

Comment 4

[Richard Newman [:rnewman]]

Not tracking; blocked on upstream.

I'm going to land the trivial fix without review, but this isn't resolved.

Comment 5

[Richard Newman [:rnewman]]

This should do it.

https://github.com/mozilla/firefox-ios/commit/c3a9c1410a69513328329dd3376d2bac0e104e5c

Comment 6

[Richard Newman [:rnewman]]

Unassigning and marking as tracking a future release to see if the upstream bug has been fixed. I can't view the duped rdar.

Comment 7

[Richard Newman [:rnewman]]

Robin, Darrin: if this is still applicable, we won't be able to remove our own extensions from the list.

Comment 8

[James Hugman [:jhugman] [@jhugman]]

I thought there may be a workaround for this, by essentially reverting half of the work for Bug 1236644.

By fixing Bug 1238807, this means that the workaround no longer works, because of http://openradar.appspot.com/radar?id=6456818549129216


ref: http://engineering.tumblr.com/post/97658880154/what-we-learned-building-the-tumblr-ios-share

Comment 9

[Jacob White]

Looks like these guys found a fix.
https://pspdfkit.com/blog/2016/hiding-action-share-extensions-in-your-own-apps/?utm_campaign=iOS%2BDev%2BWeekly&utm_medium=email&utm_source=iOS_Dev_Weekly_Issue_280