1408067 - Add Send to Device entry point to the Page Action Menu.

Status: VERIFIED FIXED

(Firefox for iOS :: Menu and Toolbar, enhancement, P2)

Description

[bbell]

Attachment: Page_Action_Menu_2x.png

Make sure users can get to "Send to Device" via the Page Action menu.

Comment 1

[Richard Newman [:rnewman]]

Gosh, yes please.

Open question: need to decide whether to filter out Send Tab from the extension list.

Bug 1184554 is relevant here.

Comment 2

[Robin Andersen [:tecgirl]]

(In reply to Richard Newman [:rnewman] from comment #1)
> Gosh, yes please.
> 
> Open question: need to decide whether to filter out Send Tab from the
> extension list.
> 
> Bug 1184554 is relevant here.

We were wondering if it's possible to add/move Send Tab to the Share Widget.

And yes, still waiting on View Later to be removed when not in Firefox.

Comment 3

[Richard Newman [:rnewman]]

(In reply to Robin Andersen [:tecgirl] from comment #2)

> We were wondering if it's possible to add/move Send Tab to the Share Widget.

You mean alongside Add Bookmark and Add to Reading List? It's technically possible.

But to noodle for a moment on the meanings of the two rows…


On the top 'Share' row we have Pocket, Mail, Twitter, iBooks, Messages, Slack, Todoist.

On the bottom 'Action' row we have Save to Dropbox, Add to (Safari's) Reading List, Add to (Safari's) Favorites.


The distinction is supposed to be:

• Share is for sharing data with websites: posting and uploading content. ("The primary purpose of a Share extension is to help users post content." … "a convenient way to share content with other entities" … "provide a list of items that help users configure a post. For example, you might let users choose an account to post from, specify privacy settings, or autocomplete a custom text entry, such as a Twitter mention")

• Action is for doing things with data. ("An Action extension helps users view or transform content originating in a host app."… "Helps users view the current document in a different way")


The 'feel', I think, is:

Top row, color, is for sending things out into the world; things you'd find in a NASCAR strip on a website.

Bottom row, monochrome, is for working with stuff that's yours. If it feels like a clipboard, or saving, or something else you'd find in a menu, then it belongs there.


We have four capabilities:

- Saving a bookmark. Clearly this is an Action, just as it is for Safari's favorites; it shouldn't be a Share extension.
- Adding to Reading List. Similarly: "view the current document in a different way".
- View Later. Same: it's a purely local action. This is where e.g., Tweetbot puts its "Open in Firefox" button.
- Send Tab. This isn't sharing, I think: it's not "posting and uploading content" to a website, or sending it to another entity. It's much more like a remote bookmark, or adding content to Dropbox.

I think if we do some consolidation here, we should consider consolidating into a set of _Action_ extensions (anywhere from 2-4), not Share extensions.

> And yes, still waiting on View Later to be removed when not in Firefox.

You mean when inside Firefox?

Comment 4

[bbell]

(In reply to Richard Newman [:rnewman] from comment #1)
> Gosh, yes please.
> 
> Open question: need to decide whether to filter out Send Tab from the
> extension list.
> 
> Bug 1184554 is relevant here.

For sure we need in to exist as a system extension in perpetuity. And while it's redundant to show it win there while using Firefox, it's also not the worst thing to have it also show up in there too.

Comment 5

[bbell]

Attachment: sendtodevice.zip

Here are the icons needed.

Comment 6

[Callie D]

Attachment: Pull request

Comment 7

[:garvan]

Comment on attachment 8918536 [details] [review]
Pull request

Farhan away today, I'll try review

Comment 8

[:garvan]

Comment on attachment 8918536 [details] [review]
Pull request

Oops, didn't realize this was mid-review cycle when I agreed to look. Farhan back to you if that is ok.

Comment 9

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/4ca9fd81183b4eb04383f0a4e27d1a06f43a66ef

Comment 10

[Simon Basca [:SimonB]]

Verifying as fix on master 9653a62c5 & 10.0(7233). 

"Send to Device" entry point has been added to the Page Action Menu.