1184672 - [Status Bar] App-Title appearing in search bar can appear as full debug title for callscreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: 2015-07-16-09-06-48.png

Description:
When the user is in a call and on the callscreen, they may observe on dragging down the notification tray the app-title appearing in Search Bar. This appears by design for apps (such as displaying 'E-Mail' and 'Clock' in their respective apps). However, in callscreen the title in the search bar will display as:
'callscreen.gaiamobile..'
This appears to be debug and probably translates to the local page being called within the gaia codebase.

Repro Steps:
1) Update a Aries to 20150716033647
2) Receive a phone call
3) Drag down notification tray slightly as to not hide search bar
4) Observe search bar title

Actual:
Callscreen title displays as: 'callscreen.gaiamobile..'

Expected:
Callscreen title displays as: 'Callscreen'


Environmental Variables:
-----------------------------
Device: Aries 2.5
Build ID: 20150716033647
Gaia: 981c61cdeb527fac8f8383c110df0e749eff67ea
Gecko: 72835344333f
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Device: Flame 2.5
BuildID: 20150715160204
Gaia: b9968cdc4a1dee49848fed6159a59c378cea062d
Gecko: 49683d4e9ebd
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
************************

This feature is not implemented on 2.2 for flame devices
Results: Search bar does not display title

Device: Flame 2.2
BuildID: 20150715002506
Gaia: 84d0c76370dcd3d25813b00de55194730884355b
Gecko: a5db6d9850f6
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
-----------------------------


Repro frequency: 5/5
See attached: 
screenshot
logcat

Comment 1

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150716_1214.txt

Comment 2

[Gregor Wagner [:gwagner]]

Ben, any idea what could have caused this regression?

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

This hasn't been proved that it's a regression. See v2.2 behavior on comment 0 is feature is not implemented. QA-Wanted to see if this was ever implemented correctly.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

On a 7/13 build, all apps display their title as 'search the web', and starting from 7/14 apps have their respective titles and this is when the issue started to occur. Not a regression.

Comment 5

[Ben Francis [:benfrancis]]

I looked into this and intended to ask Alberto about it but I can't remember whether I did or not.

For some reason CallScreenWindows aren't getting their name set in the same way as normal AppWindows (I would expect it to say "Callscreen" rather than "callscreen.gaiamobile.org").

But that's not really the issue, the issue is that the title bar is being displayed at all, as I think previously it wasn't. I'm wondering whether there's some null check which is now evaluating as true because we're setting the name property of the app object?

Alberto, can you think why this has started appearing?

Comment 6

[Alberto Pastor [:albertopq]]

This is a regression of bug 1177477. I'll take it.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1184672-titlebar-attention > mozilla-b2g:master

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8639231 [details] [review]
[gaia] albertopq:1184672-titlebar-attention > mozilla-b2g:master

Seems simple enough that I think this is fine. Thank you!

Comment 10

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/f0eebf83d57397bc5fd95ccbbe55b5ae3a0d5815

Comment 11

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Flame and Aries. However I can still reproduce the bug in another way which is setting up an ICE contact and call the ICE as an emergency number - the debug title is still displayed on that screen. I'll be filing that as a separate issue.

Note that the fixed behavior is not the expected behavior on comment 0, but rather what's being described at comment 5 - that the app title is NOT being displayed at all.

Device: Flame (full flashed 319MB KK)
BuildID: 20150731030207
Gaia: 8502d07cd7e68da79303471acf64eea48b3dce24
Gecko: ca53d4297f02
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5 Master) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Device: Aries (RC4 and OTA'ed to dogfood-latest)
BuildID: 20150731163020
Gaia: 8502d07cd7e68da79303471acf64eea48b3dce24
Gecko: ca53d4297f02
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5 Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 12

[Pi Wei Cheng [:piwei] (inactive)]

Filed bug 1189900 for the issue found at comment 11.