Closed Bug 1184700 Opened 11 years ago Closed 11 years ago

Add Sync Now button without timestamp

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bmunar, Assigned: bmunar)

References

Details

Attachments

(1 file)

PR - without timestamp
47 bytes, text/x-github-pull-request
rnewman
: review+
tecgirl
: ui-review+
Details | Review
No description provided.
Assignee: nobody → bmunar
Blocks: 1178787
Attached file PR - without timestamp —
Attachment #8634903 - Flags: review?(nalexander)
Attachment #8634903 - Flags: review?(nalexander) → review?(rnewman)
Attachment #8634903 - Flags: review?(rnewman) → feedback+
Bryan: lemme know when this is ready for re-review.
Status: NEW → ASSIGNED
Component: Browser → General
Flags: needinfo?(bmunar)
Hardware: Other → All
Flags: needinfo?(bmunar)
Attachment #8634903 - Flags: ui-review?(randersen)
Attachment #8634903 - Flags: review?(rnewman)
Comment on attachment 8634903 [details] [review] PR - without timestamp Looks good! A couple nits: Change the color from HighlightBlue to Grey. Change the weight from light to medium so it stands out more as a button. (I may change my mind about the weight, but give it a shot). Change the "Syncing…" color from DestructiveRed to orange, like we use on the progress bar. Other than that, it's quick, the state switching is good, and it works!
Attachment #8634903 - Flags: ui-review?(randersen) → ui-review+
Comment on attachment 8634903 [details] [review] PR - without timestamp Looks good with nits.
Attachment #8634903 - Flags: review?(rnewman)
Attachment #8634903 - Flags: review+
Attachment #8634903 - Flags: feedback+
Looks great! Sync Now changed to Regular weight.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: