1184740 - [Dialer] Call Banner Text becomes very large when a call is ended

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
When the user is in a call and presses the home button they will go to the homescreen with a call banner at the top of the screen that will go away after a moment. if the other user ends the call while the banner is present text on the banner will become very large. 

Repro Steps:
1) Update a Aries to 20150716033647
2) Receive a call from another device and answer
3) Press the home button
4) Hang up the other phone while the banner is present
5) Observe size of text in the banner

Actual:
The text in the banner is very large.

Expected:
It is expected that the text size remains consistent

Environmental Variables:
Device: Aries 2.5 [Full Flash]
BuildID: 20150716033647
Gaia: 981c61cdeb527fac8f8383c110df0e749eff67ea
Gecko: 72835344333f
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: Screenshot, logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on Flame 2.5.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
Build ID: 20150715160204
Gaia: b9968cdc4a1dee49848fed6159a59c378cea062d
Gecko: 49683d4e9ebd
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Result:
The text in the banner is very large.
-----------------------------------------------------
This DOES NOT occur on Flame 2.2.

Environmental Variables:
Device: Flame 2.2 [Full Flash]
BuildID: 20150715002506
Gaia: 84d0c76370dcd3d25813b00de55194730884355b
Gecko: a5db6d9850f6
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Result:
The text does not increase in size

Comment 2

[Adam Alldredge [:AdamA][Inactive]]

Attachment: Aries Call banner

Comment 3

[Adam Alldredge [:AdamA][Inactive]]

Attachment: Flame Call Banner

Comment 4

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
This looks pretty bad, requesting a window.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comms triage: Regression.

Gabriele, do you think it's a good candidate for a good first bug?

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

Yes, this is a trivial change and a regression caused by bug 1155901. Note that this happens only in English because the "Call ended" string is very short. Try another language with a longer string and the size will be more appropriate.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1184740-do-not-resize-statusbar-text > mozilla-b2g:master

Comment 9

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8654551 [details] [review]
[gaia] gabrielesvelto:bug-1184740-do-not-resize-statusbar-text > mozilla-b2g:master

Not sure what I had in mind when I wrote the original code, there's no point in resizing the string in the statusbar and to make matters worse it caused this bug. As a bonus I've noticed that we have the same problem with the number which gets an inline font-size rule attached that can make it huge in the statusbar. I'll file another bug for that.

Comment 10

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8654551 [details] [review]
[gaia] gabrielesvelto:bug-1184740-do-not-resize-statusbar-text > mozilla-b2g:master

(In reply to Gabriele Svelto [:gsvelto] from comment #9)
> Comment on attachment 8654551 [details] [review]
> [gaia] gabrielesvelto:bug-1184740-do-not-resize-statusbar-text >
> mozilla-b2g:master
> 
> I'll file another bug for that.

Yeah, please.

Also, the code directly above this is pretty bad, too. We really should not be dynamically adding stylesheets like this unless absolutely necessary, and it doesn't seem to be necessary here.

I'm also a bit disappointed that this had no test coverage.

Comment 11

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Doug Sherk (:drs) from comment #10)
> Also, the code directly above this is pretty bad, too. We really should not
> be dynamically adding stylesheets like this unless absolutely necessary, and
> it doesn't seem to be necessary here.

The dynamic style-sheet was necessary here because the screen layout is entirely dictated by CSS and so there was no programmatic way of adjusting the size for all scenarios but with a CSS selector. I'm personally in favor of moving away from this - taking the logic for displaying elements from CSS and using separate DOM elements for different looking bits instead of having CSS adapt the existing ones. As it is it's almost impossible to parse from the JS code what's going to be shown and how it will look and it's entirely non-unit-testable too.

> I'm also a bit disappointed that this had no test coverage.

There are tests but only to ensure that the strings are resized and the top-level style-sheet is created, not for the specific rules.

Comment 12

[Gabriele Svelto [:gsvelto] (PTO)]

Merged to gaia/master 805025801a68f9ddbba6ffd2ed3926c97fa7fcc8

https://github.com/mozilla-b2g/gaia/commit/805025801a68f9ddbba6ffd2ed3926c97fa7fcc8

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5&2.6 and Aires KK 2.6 by the STR in comment 0.

Actual results: The font size of the Call Banner Text shows normally when a call is ended.
See attachment: verified_Aries_v2.6.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20151102004502
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b6b410d4610da18f5e43750e67ed2c56a0c0f812
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151102.042848
Firmware Date          Mon Nov  2 04:29:02 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 (master)（Pass）
Build ID               20151102150204
Gaia Revision          7954ff0cbd794a35499a1082bed273598f82ee6f
Gaia Date              2015-11-02 17:35:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6275cd9c71b76891f6b6585dabc687bc443ab877
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151102.182914
Firmware Date          Mon Nov  2 18:29:28 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.6 (Pass)
Build ID               20151103000930
Gaia Revision          7954ff0cbd794a35499a1082bed273598f82ee6f
Gaia Date              2015-11-02 17:35:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9f69202d82752e093a653a8f15b0274e347db33a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151102.233051
Firmware Date          Mon Nov  2 23:30:58 UTC 2015
Bootloader             s1

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.5.3gp

Comment 15

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest Aires KK 2.5 by the STR in comment 0.

Actual results: The font size of the Call Banner Text shows normally when a call is ended as same as mentioned in comment 13.
See above attachment "verified_Aries_v2.6.3gp".
Reproduce rate: 0/10

Device: Aries KK 2.5 (Pass)
Build ID               20151107112205
Gaia Revision          577948202ae12154524a2bd2bd6d467838ad50b8
Gaia Date              2015-11-07 10:00:59
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151107.104119
Firmware Date          Sat Nov  7 10:41:27 UTC 2015
Bootloader             s1