1184837 - [mobile] Inconsistent button size - read more reviews on mobile

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Trishul]

Attachment: Screen Shot 2015-07-17 at 10.54.30.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150716004006

Steps to reproduce:

1. Goto https://marketplace.firefox.com/app/connecta2/ratings
2. Scroll to bottom.


Actual results:

Load more button is smaller than write a review button


Expected results:

Both buttons should be of same size.

Comment 1

[Atique Ahmed Ziad [:atiqueahmedziad]]

Attachment: myscrren.png

Comment 2

[Atique Ahmed Ziad [:atiqueahmedziad]]

can you please give your screen dimension?

Comment 3

[Trishul]

Yes its on MotoG2, 360X640

Comment 4

[Atique Ahmed Ziad [:atiqueahmedziad]]

yeah, reproducible, but i am not sure if it is by design. NI'ing phil for this :)

Comment 5

[Ram Dayal Vaishnav [:ram]]

Also NI'ing Liz for comment#4

Comment 6

[Elizabeth Hunt[:ezoehunt]]

Phil should weigh in on the sizing.

Comment 7

[Trishul]

Hi Phil,
your input on this?

Comment 8

[arushgyl]

The bug looks good.Can I work on it?

Comment 9

[shivansh bajaj]

can i work on it...

Comment 10

[Mayank Agrawal]

I want to work on this bug...

Comment 11

[Ram Dayal Vaishnav [:ram]]

arushgyl, we are waiting for Phil's input. If he confirms the bug this will be assigned to you.

Comment 12

[Philip [:pwalm]]

This will be fixed with P1.

Comment 13

[arushgyl]

Fixed it in https://github.com/mozilla/fireplace/pull/1421

Comment 14

[Atique Ahmed Ziad [:atiqueahmedziad]]

Thanks phil for the input :) 
This bug is going to be fixed in MOW phase1. So I would say to wait for the design.

(In reply to arushgyl from comment #13)
> Fixed it in https://github.com/mozilla/fireplace/pull/1421

Arushgyl, please avoid inline css for any design patch. And wait for the design to come, then you can fix it. 

Assigning myself as mentor, so if you need any help,  you can ask.

Comment 15

[Atique Ahmed Ziad [:atiqueahmedziad]]

Hi, sorry for delay,  Arushgyl, please make the load more button width to 100% upto screen with 699px. screen width greater or equal to  700px, the button width should be 300px

Helping link -
https://github.com/mozilla/fireplace/blob/master/src/media/css/buttons-loadmore.styl
https://github.com/mozilla/fireplace/blob/master/src/media/css/lib/layout.styl

Let me know if have any questions.

Comment 16

[arushgyl]

Ok will start working on it!

Comment 17

[arushgyl]

generated pull request at :-
https://github.com/mozilla/fireplace/commit/eb3e1cd0438b22a46f78e2b9ce84cf94815d241b

Comment 18

[Atique Ahmed Ziad [:atiqueahmedziad]]

As spasovski commented on your pr, please correct the minor mistakes, 

and as I give you the link earlier - https://github.com/mozilla/fireplace/blob/master/src/media/css/lib/layout.styl 

Have a look at it & make default button width 100% and when it goes to @media $base-tablet then set it to 300px.

Thanks for working on it :)

Comment 19

[arushgyl]

here

https://github.com/arush0311/fireplace/commit/b461f26a4fafe297536891b37685e2ba25dec998

Comment 20

[Ram Dayal Vaishnav [:ram]]

Hi Arush, please create a pull request and attach its links here.

FWIW - https://help.github.com/articles/creating-a-pull-request/

Comment 21

[arushgyl]

pr link-
https://github.com/mozilla/fireplace/pull/1457

Comment 22

[Atique Ahmed Ziad [:atiqueahmedziad]]

Thanks for the pr,Arush. I have added some comment in pr, please have a look at those.

Comment 23

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/pull/1457

Comment 24

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified as fixed on FF OS 2.5 (Flame), FF OS 1.4 (Inari) and FF43 (Android 4.2.1) on MP-dev.
Postfix screenshots: http://screencast.com/t/168Soa9iq
Closing bug.