Closed
Bug 1184837
Opened 9 years ago
Closed 9 years ago
[mobile] Inconsistent button size - read more reviews on mobile
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
2015-09-01
People
(Reporter: trishul.goel, Assigned: arushgyl, Mentored)
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 Build ID: 20150716004006 Steps to reproduce: 1. Goto https://marketplace.firefox.com/app/connecta2/ratings 2. Scroll to bottom. Actual results: Load more button is smaller than write a review button Expected results: Both buttons should be of same size.
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
can you please give your screen dimension?
Comment 4•9 years ago
|
||
yeah, reproducible, but i am not sure if it is by design. NI'ing phil for this :)
Flags: needinfo?(softfilebd) → needinfo?(pwalmsley)
Updated•9 years ago
|
Priority: -- → P3
Comment 9•9 years ago
|
||
can i work on it...
Comment 10•9 years ago
|
||
I want to work on this bug...
Comment 11•9 years ago
|
||
arushgyl, we are waiting for Phil's input. If he confirms the bug this will be assigned to you.
Assignee | ||
Comment 13•9 years ago
|
||
Fixed it in https://github.com/mozilla/fireplace/pull/1421
Assignee: nobody → arushgyl
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 14•9 years ago
|
||
Thanks phil for the input :) This bug is going to be fixed in MOW phase1. So I would say to wait for the design. (In reply to arushgyl from comment #13) > Fixed it in https://github.com/mozilla/fireplace/pull/1421 Arushgyl, please avoid inline css for any design patch. And wait for the design to come, then you can fix it. Assigning myself as mentor, so if you need any help, you can ask.
Mentor: softfilebd
Comment 15•9 years ago
|
||
Hi, sorry for delay, Arushgyl, please make the load more button width to 100% upto screen with 699px. screen width greater or equal to 700px, the button width should be 300px Helping link - https://github.com/mozilla/fireplace/blob/master/src/media/css/buttons-loadmore.styl https://github.com/mozilla/fireplace/blob/master/src/media/css/lib/layout.styl Let me know if have any questions.
Flags: needinfo?(arushgyl)
Assignee | ||
Comment 17•9 years ago
|
||
generated pull request at :- https://github.com/mozilla/fireplace/commit/eb3e1cd0438b22a46f78e2b9ce84cf94815d241b
Comment 18•9 years ago
|
||
As spasovski commented on your pr, please correct the minor mistakes, and as I give you the link earlier - https://github.com/mozilla/fireplace/blob/master/src/media/css/lib/layout.styl Have a look at it & make default button width 100% and when it goes to @media $base-tablet then set it to 300px. Thanks for working on it :)
Assignee | ||
Comment 19•9 years ago
|
||
here https://github.com/arush0311/fireplace/commit/b461f26a4fafe297536891b37685e2ba25dec998
Comment 20•9 years ago
|
||
Hi Arush, please create a pull request and attach its links here. FWIW - https://help.github.com/articles/creating-a-pull-request/
Assignee | ||
Comment 21•9 years ago
|
||
pr link- https://github.com/mozilla/fireplace/pull/1457
Comment 22•9 years ago
|
||
Thanks for the pr,Arush. I have added some comment in pr, please have a look at those.
Comment 23•9 years ago
|
||
https://github.com/mozilla/fireplace/pull/1457
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Target Milestone: --- → 2015-09-01
Comment 24•9 years ago
|
||
Verified as fixed on FF OS 2.5 (Flame), FF OS 1.4 (Inari) and FF43 (Android 4.2.1) on MP-dev. Postfix screenshots: http://screencast.com/t/168Soa9iq Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•