Closed Bug 1184837 Opened 7 years ago Closed 7 years ago

[mobile] Inconsistent button size - read more reviews on mobile

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Avenir
defect

Tracking

(Not tracked)

VERIFIED FIXED
2015-09-01

People

(Reporter: trishul.goel, Assigned: arushgyl, Mentored)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150716004006

Steps to reproduce:

1. Goto https://marketplace.firefox.com/app/connecta2/ratings
2. Scroll to bottom.


Actual results:

Load more button is smaller than write a review button


Expected results:

Both buttons should be of same size.
can you please give your screen dimension?
Yes its on MotoG2, 360X640
Flags: needinfo?(softfilebd)
yeah, reproducible, but i am not sure if it is by design. NI'ing phil for this :)
Flags: needinfo?(softfilebd) → needinfo?(pwalmsley)
Also NI'ing Liz for comment#4
Flags: needinfo?(ehunt)
Phil should weigh in on the sizing.
Flags: needinfo?(ehunt)
Priority: -- → P3
Hi Phil,
your input on this?
The bug looks good.Can I work on it?
can i work on it...
I want to work on this bug...
arushgyl, we are waiting for Phil's input. If he confirms the bug this will be assigned to you.
This will be fixed with P1.
Flags: needinfo?(pwalmsley)
Assignee: nobody → arushgyl
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Thanks phil for the input :) 
This bug is going to be fixed in MOW phase1. So I would say to wait for the design.

(In reply to arushgyl from comment #13)
> Fixed it in https://github.com/mozilla/fireplace/pull/1421

Arushgyl, please avoid inline css for any design patch. And wait for the design to come, then you can fix it. 

Assigning myself as mentor, so if you need any help,  you can ask.
Mentor: softfilebd
Hi, sorry for delay,  Arushgyl, please make the load more button width to 100% upto screen with 699px. screen width greater or equal to  700px, the button width should be 300px

Helping link -
https://github.com/mozilla/fireplace/blob/master/src/media/css/buttons-loadmore.styl
https://github.com/mozilla/fireplace/blob/master/src/media/css/lib/layout.styl

Let me know if have any questions.
Flags: needinfo?(arushgyl)
Ok will start working on it!
Flags: needinfo?(arushgyl)
As spasovski commented on your pr, please correct the minor mistakes, 

and as I give you the link earlier - https://github.com/mozilla/fireplace/blob/master/src/media/css/lib/layout.styl 

Have a look at it & make default button width 100% and when it goes to @media $base-tablet then set it to 300px.

Thanks for working on it :)
Hi Arush, please create a pull request and attach its links here.

FWIW - https://help.github.com/articles/creating-a-pull-request/
Thanks for the pr,Arush. I have added some comment in pr, please have a look at those.
https://github.com/mozilla/fireplace/pull/1457
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-09-01
Verified as fixed on FF OS 2.5 (Flame), FF OS 1.4 (Inari) and FF43 (Android 4.2.1) on MP-dev.
Postfix screenshots: http://screencast.com/t/168Soa9iq
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.