1185010 - [Browser][SHB] Taps on the Software Home Button will also trigger tap events in browser windows beneath the SHB.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Martin Shuman [:Marty]]

Attachment: browser-shb-logcat.txt

Description:
When the user taps the black bar for the Software Home Button, any links or tappable things below the bar will also be selected. This is most commonly seen when tapping the SHB to return to the homescreen, then returning to the browser window to find that the browser had selected a link and changed to a different web-page.

Repro Steps:
1) Update an Aries to 20150717125848
2) Connect to a WiFi or Cellular Data network and open the Browser app.
3) Perform a google search and view a search result page.
4) Scroll so that a search result link is underneath the SHB, then tap the SHB
5) Return to the browser window.

Actual:
Tapping on the SHB triggered the link, and the Browser is no longer at the search results after reopening.

Expected:
Tapping on the SHB should not trigger anything in the browser window. The Browser should still be at the search results.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150717125848
Gaia: 77bc0d940bde2a5d2d4dfadfcccc6d8d77456d36
Gecko: 15155971639c
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: Video (URL), Logcat

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on the latest Flame 2.5 build.
Tapping on the SHB triggers browser links beneath.

Environmental Variables:
Device: Flame 2.5
Build ID: 20150717010206
Gaia: 77bc0d940bde2a5d2d4dfadfcccc6d8d77456d36
Gecko: 8d262d1d0ae5
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

------------------------------------------------

This issue does NOT occur on Flame 2.2 builds.
The browser is not affected when tapping on the SHB.

Environmental Variables:
Device: Flame 2.2
Build ID: 20150715002506
Gaia: 84d0c76370dcd3d25813b00de55194730884355b
Gecko: a5db6d9850f6
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional Regression for SHB support.

Requesting a window.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue seems to have been caused by the changes for Bug 1172050.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150609110802
Gaia: 0b5638a17239080b4163cd81656028b4127f02dc
Gecko: a422730764e5
Version: 41.0a1 (2.5) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

First Broken 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150609112503
Gaia: 7d1c6d5f7d9b27b30393fd26b611ea5148088c09
Gecko: a94934fccdb2
Version: 41.0a1 (2.5) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: 0b5638a17239080b4163cd81656028b4127f02dc
Gecko: a94934fccdb2

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: 7d1c6d5f7d9b27b30393fd26b611ea5148088c09
Gecko: a422730764e5

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/0b5638a17239080b4163cd81656028b4127f02dc...7d1c6d5f7d9b27b30393fd26b611ea5148088c09

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Alberto, can you take a look at this please? This might have been caused by the landing for bug 1172050.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1185010-shb-ut > mozilla-b2g:master

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8635958 [details] [review]
[gaia] albertopq:1185010-shb-ut > mozilla-b2g:master

Thanks!

Comment 7

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/62955148918d5ca2d2d020c769411c22caf008b1

Comment 8

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest nightly build of Flame KK v2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Tapping on the SHB will not trigger browser links beneath.
See attachment: verified_Flame_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150802150204
Gaia Revision          2ca27bbdd84526c6a3b198d9cf10f2caff1dadde
Gaia Date              2015-07-31 08:23:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/32712cd01159
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150802.183402
Firmware Date          Sun Aug  2 18:34:15 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150801110932
Gaia Revision          2ca27bbdd84526c6a3b198d9cf10f2caff1dadde
Gaia Date              2015-07-31 08:23:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/32712cd01159
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150801.105449
Firmware Date          Sat Aug  1 10:54:56 UTC 2015
Bootloader             s1

Comment 9

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.3gp