Eliminate unnecessary surface lookups in SurfaceCacheImpl::Insert

Assigned to



4 years ago
2 years ago


(Reporter: seth, Assigned: seth)



Firefox Tracking Flags

(Not tracked)




4 years ago
Bug 1176124 introduced some unnecessary surface lookups in SurfaceCacheImpl::Insert(), because Insert() calls Lookup() to check if there's an existing surface or placeholder, but if there *is* a placeholder, we remove it with Remove(), which needs to do a second lookup. That's because Insert() and Remove() are implementations of the public API.

We need a private API that can do the lookup and the removal of the placeholder, if needed, in a single pass.

Comment 1

4 years ago
Ack, meant RemoveSurface() in comment 0, not Remove().
Keywords: feature
You need to log in before you can comment on or make changes to this bug.