Open Bug 1185137 Opened 5 years ago Updated 4 years ago

Eliminate unnecessary surface lookups in SurfaceCacheImpl::Insert

Categories

(Core :: ImageLib, defect)

defect
Not set
normal

Tracking

()

People

(Reporter: seth, Assigned: seth)

References

Details

(Keywords: feature)

Bug 1176124 introduced some unnecessary surface lookups in SurfaceCacheImpl::Insert(), because Insert() calls Lookup() to check if there's an existing surface or placeholder, but if there *is* a placeholder, we remove it with Remove(), which needs to do a second lookup. That's because Insert() and Remove() are implementations of the public API.

We need a private API that can do the lookup and the removal of the placeholder, if needed, in a single pass.
Ack, meant RemoveSurface() in comment 0, not Remove().
Keywords: feature
You need to log in before you can comment on or make changes to this bug.