1185137 - Eliminate unnecessary surface lookups in SurfaceCacheImpl::Insert

Status: NEW

(Core :: Graphics: ImageLib, task, P5)

Description

[Seth Fowler [:seth] [:s2h]]

Bug 1176124 introduced some unnecessary surface lookups in SurfaceCacheImpl::Insert(), because Insert() calls Lookup() to check if there's an existing surface or placeholder, but if there *is* a placeholder, we remove it with Remove(), which needs to do a second lookup. That's because Insert() and Remove() are implementations of the public API.

We need a private API that can do the lookup and the removal of the placeholder, if needed, in a single pass.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Ack, meant RemoveSurface() in comment 0, not Remove().

Comment 2

[Andrey Bienkowski]

https://bugzilla.mozilla.org/show_bug.cgi?id=1548706

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:aosmond, could you have a look please?
For more information, please visit auto_nag documentation.