1185160 - Inactive cards in task manager missing their screenshot

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Task Manager, defect)

Description

[Sam Foster [:sfoster] (he/him)]

Attachment: taskmanager-missing-screenshots.png

STR: 
1. Open one or more apps
2. From homescreen, long press on home button to show task manager

Expected results: 
Each card has a "screenshot" of the app

Actual: 
Each card just has a white background. 

If you holdhome from an active app other than homescreen, that card *will* have a screenshot. The inactive apps use a -moz-element for their background. 

In the console/logcat there are some DOMErrors, that may be related?

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: logcat.log

Attaching logcat. There's no detail in the DOMErrors, but the number of them seems like it correlates to the number of missing-screenshot cards in the task manager. 

oh, version details: 
Build ID               20150713010204
Gaia Revision          26003f00c5d527d780f8e6d417ebc966e19f24be
Gaia Date              2015-07-15 15:19:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eab21ec484bb
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  65
Firmware Date          Mon Dec 15 18:51:29 CST 2014
Bootloader             L1TC000118D0

Comment 2

[Sam Foster [:sfoster] (he/him)]

I've reset a couple of times now and not seen this. But, just now I reset with gaia/master again and made sure to open a browser window - I used cnet.com - and it reproduced for me: open cnet.com from rocketbar, tap home to return to homescreen, long press home to show task manager - and all the task manager cards are missing their backgrounds.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame
BuildID: 20150717014401
Gaia: 4a4e885c5ee1574bfef42df0d6fa74069387b5f2
Gecko: dfff4ba2e35b
Version: 42.0a1 (2.5 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

First Broken
Device: Flame
BuildID: 20150717031101
Gaia: 46b68ee1b1c4dfc26e817bac40ab16ec29901f3f
Gecko: 919c11b60471
Version: 42.0a1 (2.5 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Last Working Gaia First Broken Gecko - no repro
Gaia: 4a4e885c5ee1574bfef42df0d6fa74069387b5f2
Gecko: 919c11b60471

Last Working Gecko First Broken Gaia - repro
Gaia: 46b68ee1b1c4dfc26e817bac40ab16ec29901f3f
Gecko: dfff4ba2e35b

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/4a4e885c5ee1574bfef42df0d6fa74069387b5f2...46b68ee1b1c4dfc26e817bac40ab16ec29901f3f

Caused by changes made in Bug 1179040.

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Etienne, can you take a look at this please? This might have been caused by the landing for bug 1179040.

Comment 6

[Etienne Segonzac (:etienne)]

That's embarrassing :)

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1185160 > mozilla-b2g:master

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8636701 [details] [review]
[gaia] etiennesegonzac:bug-1185160 > mozilla-b2g:master

Took the opportunity to also fix the screenshot sizing issue (on devices with a SHB 50vh !== 50% height of an appWindow).

Comment 9

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8636701 [details] [review]
[gaia] etiennesegonzac:bug-1185160 > mozilla-b2g:master

I ran through the STR and a few other variations, with and w/o software home button. I don't quite understand why this was intermittent - from the patch it seems this should have been busted always. But, looks good to me, lets get it landed.

Comment 10

[Etienne Segonzac (:etienne)]

(In reply to Sam Foster [:sfoster] from comment #9)
> Comment on attachment 8636701 [details] [review]
> [gaia] etiennesegonzac:bug-1185160 > mozilla-b2g:master
> 
> I ran through the STR and a few other variations, with and w/o software home
> button. I don't quite understand why this was intermittent - from the patch
> it seems this should have been busted always. But, looks good to me, lets
> get it landed.

A setVisible(false)'d iframe now keeps showing content for while (gecko releases it on memory pressure), that's why edge gestures where mostly working. But launching the taskmanager was a good way to trigger the white.

Will land as soon as the build finishes :) Thanks!

Comment 11

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/428ca68c5711af761dcd77d1b6959361d9e8357a

Comment 12

[Autumn.Qiu(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Flame KK v2.5 by the STR in comment 0.

Actual results: Long press on home button to show task manager, each card has a "screenshot" of the app
See attachment: Verified_Flame_KK_v2.5.3gp
Reproduce rate: 0/10

Device: Flame KK 2.5 (Pass)
Build ID               20151025150204
Gaia Revision          1c6628ed1e40575e5ec3669ab6ef389d4ebeea65
Gaia Date              2015-10-23 17:01:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d53a52b39a95dced722cca90ac74529b66dd5253
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151025.201952
Firmware Date          Sun Oct 25 20:20:05 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

This bug also can't be reproduced on latest build of Aries KK 2.5 by the STR in comment 0.

Device: Aries KK 2.5 
Build ID               20151025085903
Gaia Revision          1c6628ed1e40575e5ec3669ab6ef389d4ebeea65
Gaia Date              2015-10-23 17:01:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d53a52b39a95dced722cca90ac74529b66dd5253
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151025.081846
Firmware Date          Sun Oct 25 08:18:54 UTC 2015
Bootloader             s1

Comment 13

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_Flame_KK_v2.5.3gp