1185268 - [yosemite][Thunderbird] Simplified Chinese shows up in Traditional Chinese mode when saving an image (attachment)

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Philip Chee]

+++ This bug was initially created as a clone of Bug #1089363 +++

(From Bug 1089363 comment #47)
> Created attachment 8548547 [details]
> Thunderbird may be affected by this bug
> 
> I wonder if Thunderbird is affected by this bug?
> The attachment is the menu from Thunderbird. It shows the simplified Chinese.
> If it is affected, we need to open a new one.
https://bug1089363.bugzilla.mozilla.org/attachment.cgi?id=8548547

(From Bug 1089363 comment #0)
> Created attachment 8511644 [details]
> Screenshot https://bug1089363.bugzilla.mozilla.org/attachment.cgi?id=8511644
> 
> The language was in Traditional Chinese, but when the user look at an image,
> right-clicked and chose "Save as", some fields in the dialog were in
> Simplified Chinese.

Comment 1

[Wayne Mery (:wsmwk)]

IS this a regression?

Comment 2

[Irvin (MozTW)]

I think this is broken by some change from OS X 10.10, not an regression.

Comment 3

[Philip Chee]

(In reply to Wayne Mery (:wsmwk, use Needinfo for questions) from comment #1)
> IS this a regression?

https://bugzilla.mozilla.org/show_bug.cgi?id=1089363#c12
OS X 10.10 and higher changed the way certain files are parsed. Or perhaps just more strict and we got away with it in the past.

Comment 4

[Kent James (:rkent)]

Should this bug be morphed into a request to uplift the patch from bug 1089363 to Thunderbird 38?

Comment 5

[Kent James (:rkent)]

After looking at bug 1089363, that is mostly for browser, so we would have to port those changes to Thunderbird.

Comment 6

[Thomasy]

Attachment: bug1185268_rev1.patch

Porting the patch according to comment 5 

Try server change-set
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7b0bb98a7e5a

Try server result
https://hg.mozilla.org/try-comm-central/rev/7b0bb98a7e5a

Comment 7

[Thomasy]

Attachment: fixed_version_dialog.png

Comment 8

[Kent James (:rkent)]

Comment on attachment 8645348 [details] [diff] [review]
bug1185268_rev1.patch

Philip Chee, could you review this and test the try-server build, since you are pushing for an uplift?

Magnus would be a better reviewer than I, but I'll try it if he does not have time.

Comment 9

[Philip Chee]

Comment on attachment 8645348 [details] [diff] [review]
bug1185268_rev1.patch

(In reply to Kent James (:rkent) from comment #8)

> Philip Chee, could you review this and test the try-server build, since you
> are pushing for an uplift?

1. I don't have an Apple. 2. L10n build configuration is a mystery to me. 3.

> Magnus would be a better reviewer than I, but I'll try it if he does not
> have time.
Jcranmer probably knows the build system better than anyone in comm-central.

Also see ewong's comment in the SeaMonkey version of this patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1185270#c5

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 8645348 [details] [diff] [review]
bug1185268_rev1.patch

Review of attachment 8645348 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 11

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/8eb72461147a

Comment 12

[Kent James (:rkent)]

Comment on attachment 8645348 [details] [diff] [review]
bug1185268_rev1.patch

https://hg.mozilla.org/releases/comm-aurora/rev/a10cac67957d
https://hg.mozilla.org/releases/comm-beta/rev/b1afb50fb6dd

I'm leaning toward not taking this in Thunderbird 38.3.0 and waiting until 38.4.0  Nobody seems to be pushing it very hard, and I don't understand the issues well enough to convince myself this is low risk.

If someone else wants to make the case for 38.3.0 there is still time. It should go in the next TB 41 beta.

Comment 13

[Kent James (:rkent)]

This does not seem to be generating any known user issues, so no real reason to take the risk for esr38.