Convert the oauth_required decorator into drf authorization and permission classes

RESOLVED FIXED

Status

Tree Management
Treeherder: API
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mdoglio, Assigned: mdoglio)

Tracking

Details

Attachments

(2 attachments)

46 bytes, text/x-github-pull-request
emorley
: review+
Details | Review | Splinter Review
46 bytes, text/x-github-pull-request
emorley
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
This is a required step for a smooth migration to a different authentication scheme.
(Assignee)

Comment 1

3 years ago
Created attachment 8637196 [details] [review]
PR 797
Assignee: nobody → mdoglio
Status: NEW → ASSIGNED
Attachment #8637196 - Flags: review?(emorley)
(Assignee)

Updated

3 years ago
Assignee: mdoglio → nobody
Status: ASSIGNED → NEW
Summary: Convert the oauth_required decorator into a drf authorizaion class → Convert the oauth_required decorator into drf authorization and permission classes
(Assignee)

Updated

3 years ago
Assignee: nobody → mdoglio
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED

Comment 2

3 years ago
Comment on attachment 8637196 [details] [review]
PR 797

The Travis run is failing
Attachment #8637196 - Flags: review?(emorley)

Updated

3 years ago
Blocks: 1160111

Updated

3 years ago
Attachment #8637196 - Flags: review?(emorley)

Comment 3

3 years ago
Comment on attachment 8637196 [details] [review]
PR 797

Looks good! Have left some comments :-)
Attachment #8637196 - Flags: review?(emorley) → review+
(Assignee)

Comment 4

3 years ago
Comments solved, I'll wait for the travis run to finish and then I'll merge it

Comment 5

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e5484eed066cfa249759902871524186ac66f533
Bug 1185520 - wrap the legacy oauth verification in drf authentication and permission classes
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 6

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/60294d05fdaefac331cfd8e03a1e2897a99c7d81
Revert "Bug 1185520 - wrap the legacy oauth verification in drf authentication and permission classes"

This reverts commit e5484eed066cfa249759902871524186ac66f533.

Comment 7

3 years ago
Will add a proper comment later, on mobile and was trying to fix task cluster issues

Updated

3 years ago
Depends on: 1187395

Comment 8

3 years ago
So unfortunately I had to back this out on Friday, since it appears to have caused mozilla-taskcluster submissions to the jobs endpoint on stage to fail with HTTP 400s (see bug 1187395) - and we needed to unblock stage/prod pushes.

Unfortunately I don't have a huge amount more info at this point, other than the first few comments in that bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

3 years ago
Created attachment 8643025 [details] [review]
PR 826
Attachment #8643025 - Flags: review?(emorley)
Comment on attachment 8643025 [details] [review]
PR 826

Looks good; have left some comments :-)
Attachment #8643025 - Flags: review?(emorley) → review+

Updated

3 years ago
Depends on: 1191252

Comment 11

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e73ce6b3fd86f3f1e4c8f099f34751cd5bbc02c3
Bug 1185520 - wrap the legacy oauth verification in drf authentication and permission classes
(Assignee)

Updated

3 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.