Closed Bug 1185520 Opened 9 years ago Closed 9 years ago

Convert the oauth_required decorator into drf authorization and permission classes

Categories

(Tree Management :: Treeherder: API, defect)

Product:
Tree Management
Component:
Treeherder: API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mdoglio, Assigned: mdoglio)

References

Details

Attachments

(2 files)

PR 797
46 bytes, text/x-github-pull-request
emorley
: review+
Details | Review
PR 826
46 bytes, text/x-github-pull-request
emorley
: review+
Details | Review
This is a required step for a smooth migration to a different authentication scheme.
Attached file PR 797 —
Assignee: nobody → mdoglio
Status: NEW → ASSIGNED
Attachment #8637196 - Flags: review?(emorley)
Assignee: mdoglio → nobody
Status: ASSIGNED → NEW
Summary: Convert the oauth_required decorator into a drf authorizaion class → Convert the oauth_required decorator into drf authorization and permission classes
Assignee: nobody → mdoglio
Status: NEW → ASSIGNED
Comment on attachment 8637196 [details] [review] PR 797 The Travis run is failing
Attachment #8637196 - Flags: review?(emorley)
Blocks: 1160111
Attachment #8637196 - Flags: review?(emorley)
Comment on attachment 8637196 [details] [review] PR 797 Looks good! Have left some comments :-)
Attachment #8637196 - Flags: review?(emorley) → review+
Comments solved, I'll wait for the travis run to finish and then I'll merge it
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/e5484eed066cfa249759902871524186ac66f533 Bug 1185520 - wrap the legacy oauth verification in drf authentication and permission classes
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/60294d05fdaefac331cfd8e03a1e2897a99c7d81 Revert "Bug 1185520 - wrap the legacy oauth verification in drf authentication and permission classes" This reverts commit e5484eed066cfa249759902871524186ac66f533.
Will add a proper comment later, on mobile and was trying to fix task cluster issues
Depends on: 1187395
So unfortunately I had to back this out on Friday, since it appears to have caused mozilla-taskcluster submissions to the jobs endpoint on stage to fail with HTTP 400s (see bug 1187395) - and we needed to unblock stage/prod pushes. Unfortunately I don't have a huge amount more info at this point, other than the first few comments in that bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file PR 826 —
Attachment #8643025 - Flags: review?(emorley)
Comment on attachment 8643025 [details] [review] PR 826 Looks good; have left some comments :-)
Attachment #8643025 - Flags: review?(emorley) → review+
Depends on: 1191252
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/e73ce6b3fd86f3f1e4c8f099f34751cd5bbc02c3 Bug 1185520 - wrap the legacy oauth verification in drf authentication and permission classes
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: